Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests for ToolStripActionList #12525

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

MelonWang1
Copy link
Contributor

@MelonWang1 MelonWang1 commented Nov 21, 2024

Related #10773

Proposed changes

  • Add unit test ToolStripActionListTests.cs for public properties and method of the ToolStripActionList.
  • Enable nullability in ToolStripActionList.
Microsoft Reviewers: Open in CodeFlow

Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.75632%. Comparing base (dc4314e) to head (ed7b62e).
Report is 8 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #12525         +/-   ##
===================================================
+ Coverage   75.74163%   75.75632%   +0.01469%     
===================================================
  Files           3157        3158          +1     
  Lines         636098      636207        +109     
  Branches       47003       47005          +2     
===================================================
+ Hits          481791      481967        +176     
+ Misses        150846      150777         -69     
- Partials        3461        3463          +2     
Flag Coverage Δ
Debug 75.75632% <100.00000%> (+0.01469%) ⬆️
integration 18.18374% <ø> (-0.00149%) ⬇️
production 49.33317% <ø> (+0.02378%) ⬆️
test 97.04621% <100.00000%> (+0.00091%) ⬆️
unit 46.54537% <ø> (+0.02344%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

---- 🚨 Try these New Features:

Copy link
Member

@ricardobossan ricardobossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than small comment, LGTM

@ricardobossan ricardobossan added 📭 waiting-author-feedback The team requires more information from the author waiting-review This item is waiting on review by one or more members of team and removed waiting-review This item is waiting on review by one or more members of team labels Nov 22, 2024
@dotnet-policy-service dotnet-policy-service bot removed the 📭 waiting-author-feedback The team requires more information from the author label Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants