Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reennable test broken in Merge and fix developer usability issues #12507

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

paul1956
Copy link
Contributor

@paul1956 paul1956 commented Nov 19, 2024

Stop ProgressDialog and VBInputBox from opening in designer which will fail.
Fix missing return in Interaction.vb

Fixes Issue where trying to open 2 VB Files in Designer causes designer to fail as its not supported (Don't know issue #)
Fact was missing from WindowsFormsApplicationBaseTests in Merge.

Proposed changes

  • Fix minor issue

Customer Impact

  • Improved test and WinForm Developers will not hang it they accidently try to open design files in Visual Studio

Regression?

  • Yes (test was accidently disabled) and No fixes usability issue

Risk

  • minimal
Microsoft Reviewers: Open in CodeFlow

Stop ProgressDialog and VBInputBox from opening in designer which will fail.
Fix missing return in Interaction.vb
Copy link

codecov bot commented Nov 19, 2024

Codecov Report

Attention: Patch coverage is 77.77778% with 4 lines in your changes missing coverage. Please review.

Project coverage is 75.74307%. Comparing base (441fb2a) to head (894ba0d).

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #12507         +/-   ##
===================================================
+ Coverage   75.74060%   75.74307%   +0.00247%     
===================================================
  Files           3157        3157                 
  Lines         636104      636107          +3     
  Branches       47003       47003                 
===================================================
+ Hits          481789      481807         +18     
+ Misses        150854      150831         -23     
- Partials        3461        3469          +8     
Flag Coverage Δ
Debug 75.74307% <77.77778%> (+0.00247%) ⬆️
integration 18.17665% <13.33333%> (+0.00172%) ⬆️
production 49.31170% <73.33333%> (+0.00495%) ⬆️
test 97.04646% <100.00000%> (+0.00110%) ⬆️
unit 46.52783% <73.33333%> (+0.00853%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

---- 🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant