Ensure GDI+ is initialized for all codepaths #12501
Merged
+24
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A few places slipped through the cracks. If you call GetImageEncoders before any other System.Drawing code you will get a fatal error.
JeremyKuhne
added
the
Servicing-consider
|
Need to take this to .NET 9. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #12501 +/- ##
===================================================
- Coverage 75.72908% 75.72746% -0.00163%
===================================================
Files 3151 3151
Lines 635802 635805 +3
Branches 46978 46978
===================================================
- Hits 481487 481479 -8
- Misses 150877 150883 +6
- Partials 3438 3443 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Tanya-Solyanik
approved these changes
Nov 17, 2024
JeremyKuhne
added a commit
to JeremyKuhne/winforms
that referenced
this pull request
Nov 18, 2024
A few places slipped through the cracks. If you call GetImageEncoders before any other System.Drawing code you will get a fatal error. (Port from dotnet#12501)
JeremyKuhne
added
Servicing-approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few places slipped through the cracks. If you call GetImageEncoders before any other System.Drawing code, you will get a fatal error.
Fixes #12494
There isn't a great way to add a regression test for this as any other call that initializes GDI+ will cause the test to not find this.
Created microsoft/CsWin32#1308 to try and make this programmatic. If this ends up being problematic, we could add another core assembly
System.Private.Windows.Core.GdiPlusto handle this scenario. Said assembly would have to depend onSystem.Private.Windows.Core.Microsoft Reviewers: Open in CodeFlow