Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for MaskedTextBoxTextEditorDropDown.cs #12244

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add tests for MaskedTextBoxTextEditorDropDown.cs #12244

wants to merge 2 commits into from
+59 −0

Conversation

LeafShi1
Copy link
Member

@LeafShi1 LeafShi1 commented Sep 29, 2024 •
edited by dotnet-policy-service bot
Loading

Related #10773

Proposed changes

  • Add test file MaskedTextBoxTextEditorDropDownTests.cs for MaskedTextBoxTextEditorDropDown
Microsoft Reviewers: Open in CodeFlow

@LeafShi1 LeafShi1 requested a review from a team as a code owner September 29, 2024 10:20
@LeafShi1 LeafShi1 mentioned this pull request Sep 29, 2024
Open
@codecov Codecov
Copy link

codecov bot commented Sep 30, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.43194%. Comparing base (0d0e1c9) to head (308cf9c).
Report is 6 commits behind head on main.

Additional details and impacted files 
@@                 Coverage Diff                 @@
##                main      #12244         +/-   ##
===================================================
+ Coverage   75.42712%   75.43194%   +0.00481%     
===================================================
  Files           3102        3103          +1     
  Lines         634244      634295         +51     
  Branches       46866       46873          +7     
===================================================
+ Hits          478392      478461         +69     
+ Misses        152434      152406         -28     
- Partials        3418        3428         +10
Flag Coverage Δ
Debug 75.43194% <100.00000%> (+0.00481%) ⬆️
integration 17.97908% <ø> (-0.00050%) ⬇️
production 48.81345% <ø> (+0.00975%) ⬆️
test 97.02651% <100.00000%> (+0.00027%) ⬆️
unit 45.85111% <ø> (+0.01523%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

ricardobossan
ricardobossan reviewed Sep 30, 2024
View reviewed changes
Copy link
Member

@ricardobossan ricardobossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than small comment, LGTM

...s.Design/tests/UnitTests/System/Windows/Forms/Design/MaskedTextBoxTextEditorDropDownTests.cs
using ErrorProvider errorProvider = dropDown.TestAccessor().Dynamic._errorProvider;

// No error when setting a correct format value.
MaskedTextBox dropDownMaskedTextBox = dropDown.TestAccessor().Dynamic._cloneMtb;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add using here

@ricardobossan ricardobossan added 📭 waiting-author-feedback The team requires more information from the author waiting-review This item is waiting on review by one or more members of team labels Sep 30, 2024
@Tanya-Solyanik Tanya-Solyanik removed the waiting-review This item is waiting on review by one or more members of team label Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ricardobossan ricardobossan ricardobossan left review comments

@SimonZhao888 SimonZhao888 Awaiting requested review from SimonZhao888

@Epica3055 Epica3055 Awaiting requested review from Epica3055

@lonitra lonitra Awaiting requested review from lonitra

@Tanya-Solyanik Tanya-Solyanik Awaiting requested review from Tanya-Solyanik

At least 1 approving review is required to merge this pull request.

Assignees

@LeafShi1 LeafShi1

Labels
📭 waiting-author-feedback The team requires more information from the author
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LeafShi1 @ricardobossan @Tanya-Solyanik