[release/8.0] Avoid Creating Graphics in TabControl.WmReflectDrawItem() #12216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lonitra
changed the title
lonitra
added
🚫 * NO-MERGE *
|
No merge until servicing branch opens |
Tanya-Solyanik
approved these changes
Sep 25, 2024
lonitra
removed
the
🚫 * NO-MERGE *
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #10536, fixes #12157
Customer Impact
We are leaking a Graphics object causing the finalizer to run to dispose it, which is sub optimal. Users can also see a
OutOfMemoryExceptionsurface from this.Testing
Manual verification that leak is not present
Risk
Low. The change involves avoid creating a new Graphics object here, which is unnecessary
Microsoft Reviewers: Open in CodeFlow