Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds code coverage to FormatStringEditorTests #12208

Merged
merged 1 commit into from
Sep 30, 2024
Merged

Adds code coverage to FormatStringEditorTests #12208

merged 1 commit into from
Sep 30, 2024

Conversation

ricardobossan
Copy link
Member

@ricardobossan ricardobossan commented Sep 23, 2024 •
edited
Loading

Related #10773

Proposed changes

  • Adds code coverage to FormatStringEditor

Customer Impact

  • None

Regression?

  • No

Risk

  • Minimal

Test methodology

  • Unit tests

Test environment(s)

  • 9.0.100-rc.1.24452.12

@ricardobossan ricardobossan self-assigned this Sep 23, 2024
@ricardobossan ricardobossan mentioned this pull request Sep 23, 2024
Open
@codecov Codecov
Copy link

codecov bot commented Sep 23, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 88.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 75.42684%. Comparing base (e3efbcc) to head (2c00cc4).
Report is 24 commits behind head on main.

Additional details and impacted files 
@@                 Coverage Diff                 @@
##                main      #12208         +/-   ##
===================================================
+ Coverage   75.38243%   75.42684%   +0.04440%     
===================================================
  Files           3099        3103          +4     
  Lines         634429      634314        -115     
  Branches       46874       46876          +2     
===================================================
+ Hits          478248      478443        +195     
+ Misses        152759      152438        -321     
- Partials        3422        3433         +11
Flag Coverage Δ
Debug 75.42684% <88.00000%> (+0.04440%) ⬆️
integration 17.97520% <ø> (-0.03066%) ⬇️
production 48.80253% <ø> (+0.04842%) ⬆️
test 97.02496% <88.00000%> (-0.00082%) ⬇️
unit 45.83844% <ø> (+0.04681%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ricardobossan ricardobossan force-pushed the Issue_10773_Add_Code_Coverage_To_FormatStringEditor branch from 8cec7e7 to 9ec7126 Compare September 24, 2024 00:14
@dotnet-policy-service dotnet-policy-service bot added the draft draft PR label Sep 24, 2024
@ricardobossan ricardobossan force-pushed the Issue_10773_Add_Code_Coverage_To_FormatStringEditor branch from 9ec7126 to 6099c13 Compare September 25, 2024 14:53
@ricardobossan ricardobossan marked this pull request as ready for review September 25, 2024 14:54
@ricardobossan ricardobossan requested a review from a team as a code owner September 25, 2024 14:54
@ricardobossan ricardobossan added waiting-review This item is waiting on review by one or more members of team and removed draft draft PR labels Sep 25, 2024
@lonitra lonitra added 📭 waiting-author-feedback The team requires more information from the author and removed waiting-review This item is waiting on review by one or more members of team labels Sep 26, 2024
@dotnet-policy-service dotnet-policy-service bot removed the 📭 waiting-author-feedback The team requires more information from the author label Sep 26, 2024
@ricardobossan ricardobossan added the waiting-review This item is waiting on review by one or more members of team label Sep 26, 2024
@lonitra lonitra added 📭 waiting-author-feedback The team requires more information from the author and removed waiting-review This item is waiting on review by one or more members of team labels Sep 27, 2024
@dotnet-policy-service dotnet-policy-service bot removed the 📭 waiting-author-feedback The team requires more information from the author label Sep 28, 2024
@ricardobossan ricardobossan force-pushed the Issue_10773_Add_Code_Coverage_To_FormatStringEditor branch from 288dc1a to 6099c13 Compare September 28, 2024 01:34
@ricardobossan ricardobossan added the waiting-review This item is waiting on review by one or more members of team label Sep 28, 2024
@ricardobossan ricardobossan force-pushed the Issue_10773_Add_Code_Coverage_To_FormatStringEditor branch from 6099c13 to 612eed4 Compare September 30, 2024 15:08
@lonitra lonitra added 📭 waiting-author-feedback The team requires more information from the author and removed waiting-review This item is waiting on review by one or more members of team labels Sep 30, 2024
Adds coverage to FormatStringEditor
2c00cc4 
Related dotnet#10773

## Proposed changes

- Adds code coverage to `FormatStringEditor`

## Customer Impact

- None

## Regression?

- No

## Risk

- Minimal

## Test methodology

- Unit tests

## Test environment(s)

- 9.0.100-rc.1.24452.12
@ricardobossan ricardobossan force-pushed the Issue_10773_Add_Code_Coverage_To_FormatStringEditor branch from 612eed4 to 2c00cc4 Compare September 30, 2024 17:34
@dotnet-policy-service dotnet-policy-service bot removed the 📭 waiting-author-feedback The team requires more information from the author label Sep 30, 2024
lonitra
lonitra approved these changes Sep 30, 2024
View reviewed changes
Copy link
Member

@lonitra lonitra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@lonitra lonitra merged commit 7c9f958 into dotnet:main Sep 30, 2024
8 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0 Preview1 milestone Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lonitra lonitra lonitra approved these changes

@Tanya-Solyanik Tanya-Solyanik Awaiting requested review from Tanya-Solyanik

@SimonZhao888 SimonZhao888 Awaiting requested review from SimonZhao888

@Epica3055 Epica3055 Awaiting requested review from Epica3055

@LeafShi1 LeafShi1 Awaiting requested review from LeafShi1

Assignees

@ricardobossan ricardobossan

Labels
None yet
Projects
None yet
Milestone
10.0 Preview1
Development

Successfully merging this pull request may close these issues.
3 participants
@ricardobossan @lonitra @LeafShi1