Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit tests for PictureBoxActionList #12201

Merged
merged 6 commits into from
Oct 7, 2024
Merged

Add unit tests for PictureBoxActionList #12201

merged 6 commits into from
Oct 7, 2024

Conversation

Syareel-Sukeri
Copy link
Contributor

@Syareel-Sukeri Syareel-Sukeri commented Sep 23, 2024 •
edited by dotnet-policy-service bot
Loading

Related #10773

Proposed changes

  • Add unit test PictureBoxActionListTests.cs for public properties and method of the PictureBoxActionList.
  • Enable nullability in PictureBoxActionList.
Microsoft Reviewers: Open in CodeFlow

@Syareel-Sukeri Syareel-Sukeri requested a review from a team as a code owner September 23, 2024 09:46
@codecov Codecov
Copy link

codecov bot commented Sep 23, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.43633%. Comparing base (66894e2) to head (3e86c1b).
Report is 49 commits behind head on main.

Additional details and impacted files 
@@                 Coverage Diff                 @@
##                main      #12201         +/-   ##
===================================================
+ Coverage   75.34760%   75.43633%   +0.08872%     
===================================================
  Files           3099        3104          +5     
  Lines         634429      634331         -98     
  Branches       46874       46875          +1     
===================================================
+ Hits          478027      478516        +489     
+ Misses        152989      152387        -602     
- Partials        3413        3428         +15
Flag Coverage Δ
Debug 75.43633% <100.00000%> (+0.08872%) ⬆️
integration 17.98254% <ø> (+0.05455%) ⬆️
production 48.82150% <ø> (+0.14649%) ⬆️
test 97.02433% <100.00000%> (-0.00258%) ⬇️
unit 45.82914% <ø> (+0.03612%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

lonitra
lonitra reviewed Sep 26, 2024
View reviewed changes
Copy link
Member

@lonitra lonitra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comment, but otherwise LGTM

...indows.Forms.Design/tests/UnitTests/System/Windows/Forms/Design/PictureBoxActionListTests.cs Outdated Show resolved Hide resolved
@lonitra lonitra added the 📭 waiting-author-feedback The team requires more information from the author label Sep 26, 2024
@dotnet-policy-service dotnet-policy-service bot removed the 📭 waiting-author-feedback The team requires more information from the author label Sep 30, 2024
@Syareel-Sukeri Syareel-Sukeri added the waiting-review This item is waiting on review by one or more members of team label Sep 30, 2024
@lonitra lonitra added 📭 waiting-author-feedback The team requires more information from the author and removed waiting-review This item is waiting on review by one or more members of team labels Sep 30, 2024
@dotnet-policy-service dotnet-policy-service bot removed the 📭 waiting-author-feedback The team requires more information from the author label Oct 1, 2024
@Tanya-Solyanik Tanya-Solyanik added the 📭 waiting-author-feedback The team requires more information from the author label Oct 1, 2024
@dotnet-policy-service dotnet-policy-service bot removed the 📭 waiting-author-feedback The team requires more information from the author label Oct 2, 2024
@Syareel-Sukeri Syareel-Sukeri added the waiting-review This item is waiting on review by one or more members of team label Oct 2, 2024
@lonitra lonitra added 📭 waiting-author-feedback The team requires more information from the author and removed waiting-review This item is waiting on review by one or more members of team labels Oct 3, 2024
@dotnet-policy-service dotnet-policy-service bot removed the 📭 waiting-author-feedback The team requires more information from the author label Oct 4, 2024
@Syareel-Sukeri Syareel-Sukeri added the waiting-review This item is waiting on review by one or more members of team label Oct 7, 2024
lonitra
lonitra approved these changes Oct 7, 2024
View reviewed changes
Copy link
Member

@lonitra lonitra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lonitra lonitra added ready-to-merge PRs that are ready to merge but worth notifying the internal team. and removed waiting-review This item is waiting on review by one or more members of team labels Oct 7, 2024
Tanya-Solyanik
Tanya-Solyanik approved these changes Oct 7, 2024
View reviewed changes
Copy link
Member

@Tanya-Solyanik Tanya-Solyanik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Tanya-Solyanik Tanya-Solyanik merged commit f7107b4 into dotnet:main Oct 7, 2024
8 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0 Preview1 milestone Oct 7, 2024
@dotnet-policy-service dotnet-policy-service bot removed the ready-to-merge PRs that are ready to merge but worth notifying the internal team. label Oct 7, 2024
@LeafShi1 LeafShi1 mentioned this pull request Oct 8, 2024
Open
@Syareel-Sukeri Syareel-Sukeri deleted the AddCodeCovPictureBoxActionList branch October 24, 2024 08:18
@Syareel-Sukeri Syareel-Sukeri restored the AddCodeCovPictureBoxActionList branch October 24, 2024 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lonitra lonitra lonitra approved these changes

@Tanya-Solyanik Tanya-Solyanik Tanya-Solyanik approved these changes

Assignees

@Syareel-Sukeri Syareel-Sukeri

Labels
None yet
Projects
None yet
Milestone
10.0 Preview1
Development

Successfully merging this pull request may close these issues.
3 participants
@Syareel-Sukeri @Tanya-Solyanik @lonitra