-
Notifications
You must be signed in to change notification settings - Fork 971
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add unit tests for ToolStripContainerDesigner #12200
Open
Olina-Zhang
wants to merge
2
commits into
dotnet:main
Choose a base branch
from
Olina-Zhang:UnitTest_ToolStripContainerDesigner
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add unit tests for ToolStripContainerDesigner #12200
Olina-Zhang
wants to merge
2
commits into
dotnet:main
from
Olina-Zhang:UnitTest_ToolStripContainerDesigner
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #12200 +/- ##
===================================================
+ Coverage 75.26640% 75.44071% +0.17430%
===================================================
Files 3086 3103 +17
Lines 633636 634322 +686
Branches 46839 46870 +31
===================================================
+ Hits 476915 478537 +1622
+ Misses 153316 152356 -960
- Partials 3405 3429 +24
Flags with carried forward coverage won't be shown. Click here to find out more. |
lonitra
reviewed
Sep 26, 2024
....Forms.Design/tests/UnitTests/System/Windows/Forms/Design/ToolStripContainerDesignerTests.cs
Outdated
Show resolved
Hide resolved
....Forms.Design/tests/UnitTests/System/Windows/Forms/Design/ToolStripContainerDesignerTests.cs
Show resolved
Hide resolved
....Forms.Design/tests/UnitTests/System/Windows/Forms/Design/ToolStripContainerDesignerTests.cs
Outdated
Show resolved
Hide resolved
....Forms.Design/tests/UnitTests/System/Windows/Forms/Design/ToolStripContainerDesignerTests.cs
Outdated
Show resolved
Hide resolved
lonitra
added
the
📭 waiting-author-feedback
The team requires more information from the author
label
Sep 26, 2024
dotnet-policy-service
bot
removed
the
📭 waiting-author-feedback
The team requires more information from the author
label
Sep 29, 2024
lonitra
reviewed
Sep 30, 2024
Comment on lines
+95
to
+108
public void Initialize_ShouldSetShadowProperties() | ||
{ | ||
AssertShadowProperties("TopToolStripPanelVisible", _toolStripContainer.TopToolStripPanelVisible); | ||
AssertShadowProperties("LeftToolStripPanelVisible", _toolStripContainer.LeftToolStripPanelVisible); | ||
AssertShadowProperties("RightToolStripPanelVisible", _toolStripContainer.RightToolStripPanelVisible); | ||
AssertShadowProperties("BottomToolStripPanelVisible", _toolStripContainer.BottomToolStripPanelVisible); | ||
} | ||
|
||
private void AssertShadowProperties(string propertyName, object expectedValue) | ||
{ | ||
var property = typeof(ToolStripContainerDesigner).GetProperty(propertyName, BindingFlags.NonPublic | BindingFlags.Instance); | ||
var actualValue = property?.GetValue(_designer); | ||
actualValue.Should().Be(expectedValue); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
public void Initialize_ShouldSetShadowProperties() | |
{ | |
AssertShadowProperties("TopToolStripPanelVisible", _toolStripContainer.TopToolStripPanelVisible); | |
AssertShadowProperties("LeftToolStripPanelVisible", _toolStripContainer.LeftToolStripPanelVisible); | |
AssertShadowProperties("RightToolStripPanelVisible", _toolStripContainer.RightToolStripPanelVisible); | |
AssertShadowProperties("BottomToolStripPanelVisible", _toolStripContainer.BottomToolStripPanelVisible); | |
} | |
private void AssertShadowProperties(string propertyName, object expectedValue) | |
{ | |
var property = typeof(ToolStripContainerDesigner).GetProperty(propertyName, BindingFlags.NonPublic | BindingFlags.Instance); | |
var actualValue = property?.GetValue(_designer); | |
actualValue.Should().Be(expectedValue); | |
} | |
public void Initialize_ShouldSetShadowProperties() | |
{ | |
AssertShadowProperties("TopToolStripPanelVisible", _toolStripContainer.TopToolStripPanelVisible); | |
AssertShadowProperties("LeftToolStripPanelVisible", _toolStripContainer.LeftToolStripPanelVisible); | |
AssertShadowProperties("RightToolStripPanelVisible", _toolStripContainer.RightToolStripPanelVisible); | |
AssertShadowProperties("BottomToolStripPanelVisible", _toolStripContainer.BottomToolStripPanelVisible); | |
void AssertShadowProperties(string propertyName, object expectedValue) | |
{ | |
var property = typeof(ToolStripContainerDesigner).GetProperty(propertyName, BindingFlags.NonPublic | BindingFlags.Instance); | |
var actualValue = property?.GetValue(_designer); | |
actualValue.Should().Be(expectedValue); | |
} | |
} |
lonitra
added
the
📭 waiting-author-feedback
The team requires more information from the author
label
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #10773
Proposed changes
Microsoft Reviewers: Open in CodeFlow