Add unit tests for ItemTypeToolStripMenuItem #12199
Open
+58
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12199 +/- ##
===================================================
+ Coverage 75.34760% 75.44109% +0.09349%
===================================================
Files 3099 3104 +5
Lines 634429 634340 -89
Branches 46874 46876 +2
===================================================
+ Hits 478027 478553 +526
+ Misses 152989 152360 -629
- Partials 3413 3427 +14
Flags with carried forward coverage won't be shown. Click here to find out more. |
Syareel-Sukeri
added
the
waiting-review
Epica3055
reviewed
Sep 25, 2024
...s.Forms.Design/tests/UnitTests/System/Windows/Forms/Design/ItemTypeToolStripMenuItemTests.cs
Outdated
Show resolved
Hide resolved
Epica3055
added
📭 waiting-author-feedback
dotnet-policy-service
bot
removed
the
📭 waiting-author-feedback
Syareel-Sukeri
added
the
waiting-review
lonitra
reviewed
Sep 30, 2024
...s.Forms.Design/tests/UnitTests/System/Windows/Forms/Design/ItemTypeToolStripMenuItemTests.cs
Outdated
Show resolved
Hide resolved
...s.Forms.Design/tests/UnitTests/System/Windows/Forms/Design/ItemTypeToolStripMenuItemTests.cs
Outdated
Show resolved
Hide resolved
lonitra
added
📭 waiting-author-feedback
dotnet-policy-service
bot
removed
the
📭 waiting-author-feedback
...s.Forms.Design/tests/UnitTests/System/Windows/Forms/Design/ItemTypeToolStripMenuItemTests.cs
Outdated
Show resolved
Hide resolved
| [Fact] | ||
| public void Dispose_SetsToolboxItemToNull() | ||
| { | ||
| ItemTypeToolStripMenuItem item = new(typeof(string)); |
There was a problem hiding this comment.
This is a Component, please dispose it.
There was a problem hiding this comment.
In fact, you can factor out ItemTypeToolStripMenuItem into a field and allocate it in the Test class constructor, make the test class an IDisposable and dispose the item when the test class is disposed.
Tanya-Solyanik
added
the
📭 waiting-author-feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #10773
Proposed changes
Microsoft Reviewers: Open in CodeFlow