Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds code coverage to FormatControl #12168

Conversation

ricardobossan
Copy link
Member

@ricardobossan ricardobossan commented Sep 18, 2024

Related #10773

Proposed changes

  • Adds code coverage to FormatControl.

Customer Impact

  • None

Regression?

  • No

Risk

  • Minimal

Test methodology

  • Unit tests

Test environment(s)

  • 9.0.100-rc.1.24452.12
Microsoft Reviewers: Open in CodeFlow

Related dotnet#10773

## Proposed changes

- Adds code coverage to `FormatControl`.

## Customer Impact

- None

## Regression?

- No

## Risk

- Minimal

## Test methodology

- Unit tests

## Test environment(s)

- 9.0.100-rc.1.24452.12
@ricardobossan ricardobossan added the waiting-review This item is waiting on review by one or more members of team label Sep 18, 2024
@ricardobossan ricardobossan self-assigned this Sep 18, 2024
@ricardobossan ricardobossan requested a review from a team as a code owner September 18, 2024 09:01
Copy link
Member

@Epica3055 Epica3055 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good 👍

Copy link
Member

@lonitra lonitra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lonitra lonitra merged commit ea207b7 into dotnet:main Sep 18, 2024
8 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0 Preview1 milestone Sep 18, 2024
@dotnet-policy-service dotnet-policy-service bot removed the waiting-review This item is waiting on review by one or more members of team label Sep 18, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Oct 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants