Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Unit test coverage for the PropertyGrid class #12098

Merged
merged 19 commits into from
Oct 11, 2024
Merged

Add Unit test coverage for the PropertyGrid class #12098

merged 19 commits into from
Oct 11, 2024

Conversation

John-Qiao
Copy link
Member

@John-Qiao John-Qiao commented Sep 10, 2024 •
edited by dotnet-policy-service bot
Loading

Related #12055

Proposed changes

  • Add unit test for PropertyGrid 49 properties and methods in PropertyGridTests.cs file.
  • Enable nullability in PropertyGridTests.
Microsoft Reviewers: Open in CodeFlow

@John-Qiao John-Qiao requested a review from a team as a code owner September 10, 2024 10:42
@John-Qiao John-Qiao added the waiting-review This item is waiting on review by one or more members of team label Sep 10, 2024
@Tanya-Solyanik
Copy link
Member

@John-Qiao - please fix the build failure

@Tanya-Solyanik Tanya-Solyanik added 📭 waiting-author-feedback The team requires more information from the author and removed waiting-review This item is waiting on review by one or more members of team labels Sep 10, 2024
@dotnet-policy-service dotnet-policy-service bot removed the 📭 waiting-author-feedback The team requires more information from the author label Sep 11, 2024
@codecov Codecov
Copy link

codecov bot commented Sep 11, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 99.64664% with 1 line in your changes missing coverage. Please review.

Project coverage is 75.51361%. Comparing base (8d231a0) to head (59f58ac).
Report is 138 commits behind head on main.

Additional details and impacted files 
@@                 Coverage Diff                 @@
##                main      #12098         +/-   ##
===================================================
+ Coverage   75.16050%   75.51361%   +0.35311%     
===================================================
  Files           3070        3107         +37     
  Lines         632557      634728       +2171     
  Branches       46787       46890        +103     
===================================================
+ Hits          475433      479306       +3873     
+ Misses        153740      151963       -1777     
- Partials        3384        3459         +75
Flag Coverage Δ
Debug 75.51361% <99.64664%> (+0.35311%) ⬆️
integration 18.29185% <ø> (+0.32863%) ⬆️
production 48.96057% <ø> (+0.57916%) ⬆️
test 97.02821% <99.64664%> (+0.00809%) ⬆️
unit 45.89613% <ø> (+0.49479%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@Tanya-Solyanik Tanya-Solyanik added the 📭 waiting-author-feedback The team requires more information from the author label Sep 11, 2024
LeafShi1
LeafShi1 requested changes Sep 12, 2024
View reviewed changes
src/System.Windows.Forms/tests/IntegrationTests/UIIntegrationTests/PropertyGridTests.cs Outdated Show resolved Hide resolved
src/System.Windows.Forms/tests/IntegrationTests/UIIntegrationTests/PropertyGridTests.cs Outdated Show resolved Hide resolved
src/System.Windows.Forms/tests/IntegrationTests/UIIntegrationTests/PropertyGridTests.cs Outdated Show resolved Hide resolved
src/System.Windows.Forms/tests/IntegrationTests/UIIntegrationTests/PropertyGridTests.cs Outdated Show resolved Hide resolved
src/System.Windows.Forms/tests/IntegrationTests/UIIntegrationTests/PropertyGridTests.cs Show resolved Hide resolved
src/System.Windows.Forms/tests/IntegrationTests/UIIntegrationTests/PropertyGridTests.cs Outdated Show resolved Hide resolved
src/System.Windows.Forms/tests/IntegrationTests/UIIntegrationTests/PropertyGridTests.cs Outdated Show resolved Hide resolved
src/System.Windows.Forms/tests/IntegrationTests/UIIntegrationTests/PropertyGridTests.cs Show resolved Hide resolved
@dotnet-policy-service dotnet-policy-service bot removed the 📭 waiting-author-feedback The team requires more information from the author label Sep 12, 2024
@Tanya-Solyanik Tanya-Solyanik added the 📭 waiting-author-feedback The team requires more information from the author label Sep 13, 2024
@dotnet-policy-service dotnet-policy-service bot removed the 📭 waiting-author-feedback The team requires more information from the author label Sep 18, 2024
@John-Qiao John-Qiao added the waiting-review This item is waiting on review by one or more members of team label Sep 20, 2024
@Tanya-Solyanik Tanya-Solyanik added 📭 waiting-author-feedback The team requires more information from the author and removed waiting-review This item is waiting on review by one or more members of team labels Sep 30, 2024
@dotnet-policy-service dotnet-policy-service bot removed the 📭 waiting-author-feedback The team requires more information from the author label Oct 8, 2024
@lonitra lonitra added the 📭 waiting-author-feedback The team requires more information from the author label Oct 8, 2024
@dotnet-policy-service dotnet-policy-service bot removed the 📭 waiting-author-feedback The team requires more information from the author label Oct 9, 2024
Tanya-Solyanik
Tanya-Solyanik approved these changes Oct 9, 2024
View reviewed changes
Copy link
Member

@Tanya-Solyanik Tanya-Solyanik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Tanya-Solyanik
Copy link
Member

@LeafShi1 - please re-review this PR

@lonitra lonitra requested a review from LeafShi1 October 10, 2024 16:51
@LeafShi1 LeafShi1 merged commit 656dc81 into dotnet:main Oct 11, 2024
8 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0 Preview1 milestone Oct 11, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Nov 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Epica3055 Epica3055 Epica3055 left review comments

@lonitra lonitra lonitra left review comments

@LeafShi1 LeafShi1 LeafShi1 approved these changes

@Tanya-Solyanik Tanya-Solyanik Tanya-Solyanik approved these changes

@ricardobossan ricardobossan Awaiting requested review from ricardobossan

@SimonZhao888 SimonZhao888 Awaiting requested review from SimonZhao888

Assignees

@John-Qiao John-Qiao

Labels
None yet
Projects
None yet
Milestone
10.0 Preview1
Development

Successfully merging this pull request may close these issues.
5 participants
@John-Qiao @Tanya-Solyanik @lonitra @LeafShi1 @Epica3055