Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests for DateTimePickerDesigner #11702

Merged
merged 2 commits into from
Jul 19, 2024

Conversation

Olina-Zhang
Copy link
Member

@Olina-Zhang Olina-Zhang commented Jul 18, 2024

Related #10773

Proposed changes

  • Add unit test file: DateTimePickerDesignerTests.cs for public properties of the DateTimePickerDesigner
Microsoft Reviewers: Open in CodeFlow

Copy link

codecov bot commented Jul 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.68021%. Comparing base (bb601b3) to head (d7d8983).
Report is 17 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #11702         +/-   ##
===================================================
+ Coverage   74.65248%   74.68021%   +0.02773%     
===================================================
  Files           3042        3044          +2     
  Lines         629821      630483        +662     
  Branches       46847       46847                 
===================================================
+ Hits          470177      470846        +669     
- Misses        156275      156276          +1     
+ Partials        3369        3361          -8     
Flag Coverage Δ
Debug 74.68021% <100.00000%> (+0.02773%) ⬆️
integration 17.86872% <ø> (-0.08043%) ⬇️
production 47.64240% <ø> (-0.00199%) ⬇️
test 96.98670% <100.00000%> (+0.00845%) ⬆️
unit 44.74677% <ø> (+0.05583%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@elachlan elachlan added the waiting-review This item is waiting on review by one or more members of team label Jul 18, 2024
bool autoResizeHandles = dateTimePickerDesigner.AutoResizeHandles;

dateTimePickerDesigner.Should().NotBeNull();
autoResizeHandles.Should().Be(true);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
autoResizeHandles.Should().Be(true);
autoResizeHandles.Should().BeTrue();

@lonitra lonitra added 📭 waiting-author-feedback The team requires more information from the author and removed waiting-review This item is waiting on review by one or more members of team labels Jul 18, 2024
@dotnet-policy-service dotnet-policy-service bot removed the 📭 waiting-author-feedback The team requires more information from the author label Jul 19, 2024
Copy link
Member

@lonitra lonitra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@lonitra
Copy link
Member

lonitra commented Jul 19, 2024

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@lonitra lonitra enabled auto-merge (squash) July 19, 2024 16:34
@lonitra lonitra merged commit bc186fe into dotnet:main Jul 19, 2024
8 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the 9.0 Preview7 milestone Jul 19, 2024
@Olina-Zhang Olina-Zhang deleted the UnitTest_DateTimePickerDesigner branch July 22, 2024 01:26
@github-actions github-actions bot locked and limited conversation to collaborators Aug 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants