Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests for ButtonBaseDesigner #11690

Merged

Conversation

LeafShi1
Copy link
Member

@LeafShi1 LeafShi1 commented Jul 17, 2024

Related #10773

Proposed changes

  • Add unit test ButtonBaseDesignerTests.cs for public properties and method of the ButtonBaseDesigner
Microsoft Reviewers: Open in CodeFlow

@LeafShi1 LeafShi1 requested a review from a team as a code owner July 17, 2024 08:15
@LeafShi1 LeafShi1 force-pushed the Add_tests_for_ButtonBaseDesigner branch from ec50268 to 12a5a1c Compare July 17, 2024 08:32
@LeafShi1 LeafShi1 force-pushed the Add_tests_for_ButtonBaseDesigner branch from 12a5a1c to a3648d1 Compare July 17, 2024 08:35
Copy link

codecov bot commented Jul 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.73683%. Comparing base (fa07c1b) to head (1d6e1b5).
Report is 37 commits behind head on feature/10.0.

Additional details and impacted files
@@                  Coverage Diff                   @@
##           feature/10.0      #11690         +/-   ##
======================================================
+ Coverage      74.55969%   74.73683%   +0.17713%     
======================================================
  Files              3041        3046          +5     
  Lines            629780      630665        +885     
  Branches          46845       46862         +17     
======================================================
+ Hits             469562      471339       +1777     
+ Misses           156849      155955        -894     
- Partials           3369        3371          +2     
Flag Coverage Δ
Debug 74.73683% <100.00000%> (+0.17713%) ⬆️
integration 17.95130% <ø> (+0.07854%) ⬆️
production 47.75653% <ø> (+0.30979%) ⬆️
test 96.98586% <100.00000%> (+0.00760%) ⬆️
unit 44.80347% <ø> (+0.23101%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ricardobossan ricardobossan added the 📭 waiting-author-feedback The team requires more information from the author label Jul 17, 2024
@dotnet-policy-service dotnet-policy-service bot removed the 📭 waiting-author-feedback The team requires more information from the author label Jul 18, 2024
@elachlan elachlan added the waiting-review This item is waiting on review by one or more members of team label Jul 18, 2024
SimonZhao888
SimonZhao888 previously approved these changes Jul 19, 2024
@lonitra lonitra added 📭 waiting-author-feedback The team requires more information from the author and removed waiting-review This item is waiting on review by one or more members of team labels Jul 19, 2024
@dotnet-policy-service dotnet-policy-service bot removed the 📭 waiting-author-feedback The team requires more information from the author label Jul 22, 2024
Copy link
Member

@Tanya-Solyanik Tanya-Solyanik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Tanya-Solyanik Tanya-Solyanik added the 📭 waiting-author-feedback The team requires more information from the author label Jul 22, 2024
@lonitra lonitra changed the base branch from main to feature/10.0 July 23, 2024 00:54
@dotnet-policy-service dotnet-policy-service bot removed the 📭 waiting-author-feedback The team requires more information from the author label Jul 23, 2024
@Tanya-Solyanik Tanya-Solyanik merged commit 2c02ca5 into dotnet:feature/10.0 Jul 23, 2024
8 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 23, 2024
@LeafShi1 LeafShi1 deleted the Add_tests_for_ButtonBaseDesigner branch September 5, 2024 09:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants