Update OmniSharp to 1.39.12 #7445
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoeRobich
commented
Aug 15, 2024
| } catch (error) { | ||
| this.eventStream.post(new InstallationFailure('getLatestVersionInfoFile', error)); | ||
| throw error; | ||
| } | ||
| } | ||
|
|
||
| public async fetchLatestReleases(urlString: string): Promise<any> { |
There was a problem hiding this comment.
This is mostly the existing downloadFile with cancellation and progress reporting removed.
|
|
||
| public constructor( | ||
| private downloader: OmnisharpDownloader, | ||
| private platformInfo: PlatformInformation, | ||
| // Only the tests set this. Instead of making this configurable, | ||
| // we should probably just mock the HTTP requests, not create an entire mock HTTP server. | ||
| private serverUrl: string = 'https://roslynomnisharp.blob.core.windows.net' | ||
| private serverUrl: string | undefined = undefined |
There was a problem hiding this comment.
Continue to use this for tests to override. However, now that we need separate urls for downloading builds and finding latest version, we do not initialize this and allow each method to supply the correct production url.
| // Omnisharp versions are always after the last '-'. | ||
| // e.g. we want omnisharp-win-x86 from omnisharp-win-x86-1.39.3.zip | ||
| const lastDash = fileName.lastIndexOf('-'); | ||
| fileName = fileName.substr(0, lastDash); | ||
| return fileName; |
There was a problem hiding this comment.
GH release builds do not contain the version number in the filename.
JoeRobich
force-pushed
the
dev/jorobich/omnisharp-github-releases
branch
from
b655b51
to
305fc7d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition to updating O#, this also changes where the latest builds of O# are discovered. The C# extension will now download O# from its GitHub releases.