Allow rzls to launch using standard dotnet #5855
Open
+89
−72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR has two purposes: 1. Carving a path out where by we can ship rzls in a non-self contained fashion. 2. Unify the `dotnet` acquisition and launch process between the razor and roslyn servers This is my first every TypeScript PR so please be gentle 😄
|
This is the bit I think you could pass into Razor and re-use |
|
Well at least it looks like I was on the right track here. |
maryamariyan
added a commit
that referenced
this pull request
Feb 1, 2024
- Updates where to pick up dotnet.exe. - Contributes to making rzls move away from being self-contained. - Unifies how roslyn and razor servers acquire dotnet path/env variables. - Picks up leftover changes from #5855 into main
This was referenced Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has two purposes:
dotnetacquisition and launch process between the razor and roslyn serversThis is my first every TypeScript PR so please be gentle 😄