Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

format: stop checking for dotnet cli version #44958

Open
wants to merge 3 commits into
base: release/9.0.2xx
Choose a base branch
from
Open

format: stop checking for dotnet cli version #44958

wants to merge 3 commits into from
+0 −94

Conversation

RikkiGibson
Copy link
Contributor

dotnet/format#2218

@JoeRobich does this seem like a reasonable step to get more info about the issue?

@RikkiGibson RikkiGibson requested a review from a team as a code owner November 19, 2024 18:39
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Infrastructure untriaged Request triage from a team member labels Nov 19, 2024
This was referenced Nov 19, 2024
Open
Open
@RikkiGibson
Copy link
Contributor Author

@dotnet/roslyn-ide for review

@RikkiGibson
Copy link
Contributor Author

@Cosifne @dotnet/roslyn-ide for review

@Cosifne
Copy link
Member

Cosifne commented Nov 20, 2024

Might better to get a review from Joey as I am unfamiliar with the format codebase

@JoeRobich
Copy link
Member

I am thinking that since dotnet-format is building out of the SDK repo. The dotnet CLI version and the dotnet-format version should be the "same", although it appears that the CLI's version truncates the specifics of the build number. We may just want to ditch logging the CLI version as it should be matched.

@RikkiGibson
Copy link
Contributor Author

Per offline discussion we think we just shouldn't do this check any more because we are shipping in the sdk anyway. @JoeRobich

@RikkiGibson RikkiGibson changed the title Log the exception from 'dotnet --version' command format: stop checking for dotnet cli verison Nov 20, 2024
@RikkiGibson RikkiGibson changed the title format: stop checking for dotnet cli verison format: stop checking for dotnet cli version Nov 20, 2024
@RikkiGibson RikkiGibson enabled auto-merge (squash) November 20, 2024 21:58
@RikkiGibson
Copy link
Contributor Author

It looks like the macOS job has failed after 3 attempts. The only test results appear to be failing work items. The helix logs are very verbose and I'm having difficulty interpreting what is failing here.

@ViktorHofer @MiYanni do you have any insight into what is failing in CI here?

@ViktorHofer
Copy link
Member

I took a brief look but no idea, sorry. Someone from the sdk team should be able to help. cc @joeloff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoeRobich JoeRobich JoeRobich approved these changes

Assignees
No one assigned
Labels
Area-Infrastructure untriaged Request triage from a team member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RikkiGibson @Cosifne @JoeRobich @ViktorHofer