Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgraded logging for #595 log url when connection is closed #44953

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

SimaTian
Copy link

One of the customers run into an issue with insufficient logging:
While I think the logging was since improved, this is my attempt to increase the granularity from a generic fail for download/upload repository interaction to a separate error for download and upload.

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Containers Related to dotnet SDK containers functionality untriaged Request triage from a team member labels Nov 19, 2024
@SimaTian
Copy link
Author

Previously there was already an url mentioned, so I believe this issue was already resolved before I started.
image
Note: the error is one I artificially threw to reproduce. The relevant part is the "D:\sdk\artifacts\bin\redist\Debug\dotnet\sdk\10.0.100-dev\Containers\build\Microsoft.NET.Build.Containers.targets(242,5): error CONTAINER1013: Failed to push to the output registry: " part of the original log.

That being said, the error message didn't differentiate between upload and fetch failures which I remedied:
The updated logging in case of pull failure:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Containers Related to dotnet SDK containers functionality untriaged Request triage from a team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants