Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial attempt at removing explicit #nullable enable in source #44936

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Commits on Mar 6, 2024

  1. Removed the explicit, in-code #nullable enable statements. Started fi…

    …xing projects previously using these statements to now use <Nullable>enable</Nullable>. Got the Microsoft.DotNet.Cli.Utils.csproj building. More to come.
    MiYanni committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    265f486 View commit details
    Browse the repository at this point in the history

Commits on Mar 28, 2024

  1. Configuration menu
    Copy the full SHA
    1240664 View commit details
    Browse the repository at this point in the history
  2. Got Microsoft.NET.Sdk.WorkloadMSBuildSdkResolver.csproj building with…

    … nullable enable. Added WorkloadRootPath.cs since the tuples were problematic with nullability logic.
    MiYanni committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    4ddb7b2 View commit details
    Browse the repository at this point in the history

Commits on Apr 2, 2024

  1. Configuration menu
    Copy the full SHA
    9ef3407 View commit details
    Browse the repository at this point in the history
  2. Had to set #nullable enable in the PublicAPI files. https://github.co…

    …m/dotnet/roslyn-analyzers/blob/main/src/PublicApiAnalyzers/PublicApiAnalyzers.Help.md#nullable-reference-type-support Converted Microsoft.DotNet.Configurer.csproj to nullable. Realized the other projects that need nullable are massive, so putting this on the backburner.
    MiYanni committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    6cee400 View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2024

  1. Merge branch 'main' into RemoveExplicitNullableSetters2

    # Conflicts:
    #	src/Cli/Microsoft.DotNet.Cli.Utils/Microsoft.DotNet.Cli.Utils.csproj
    #	src/Cli/Microsoft.DotNet.Cli.Utils/UILanguageOverride.cs
    #	src/Cli/dotnet/dotnet.csproj
    #	src/Common/WorkloadFileBasedInstall.cs
    #	src/Containers/Microsoft.NET.Build.Containers/LocalDaemons/DockerCli.cs
    #	src/Resolvers/Microsoft.DotNet.NativeWrapper/Microsoft.DotNet.NativeWrapper.csproj
    #	src/Resolvers/Microsoft.NET.Sdk.WorkloadManifestReader/SdkDirectoryWorkloadManifestProvider.cs
    #	src/Resolvers/Microsoft.NET.Sdk.WorkloadManifestReader/WorkloadInstallType.cs
    #	src/Resolvers/Microsoft.NET.Sdk.WorkloadManifestReader/WorkloadResolver.cs
    #	src/Tasks/Common/NuGetUtils.cs
    #	src/WebSdk/Publish/Tasks/Microsoft.NET.Sdk.Publish.Tasks.csproj
    #	src/WebSdk/Publish/Tasks/MsDeploy/CommonUtility.cs
    #	src/WebSdk/Publish/Tasks/Tasks/MsDeploy/MSDeploy.cs
    #	src/WebSdk/Publish/Tasks/Tasks/MsDeploy/VsMsdeploy.cs
    #	src/WebSdk/Publish/Tasks/Tasks/WebJobs/GenerateRunCommandFile.cs
    #	src/WebSdk/Publish/Tasks/Tasks/ZipDeploy/HttpClientHelpers.cs
    #	src/WebSdk/Publish/Tasks/Tasks/ZipDeploy/HttpResponseMessageWrapper.cs
    #	src/WebSdk/Publish/Tasks/WebJobsCommandGenerator.cs
    MiYanni committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    9f55711 View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2024

  1. Configuration menu
    Copy the full SHA
    2a5ca26 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3d4ea3e View commit details
    Browse the repository at this point in the history
  3. Fixes based on looking over the PR diff. Removed commented code and a…

    …ccidental removal of nullable on the WorkloadManifestReader.
    MiYanni committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    cd3b4e6 View commit details
    Browse the repository at this point in the history