[release/8.0.2xx] Update dependencies from dotnet/roslyn #37801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dotnet-maestro[bot]](https://avatars.githubusercontent.com/in/16706?s=60&v=4){kind=small}
…104.13 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.CodeAnalysis.CSharp.CodeStyle , Microsoft.CodeAnalysis.CSharp.Features , Microsoft.CodeAnalysis.CSharp.Workspaces , Microsoft.CodeAnalysis.Workspaces.MSBuild , Microsoft.Net.Compilers.Toolset From Version 4.9.0-3.24053.1 -> To Version 4.9.0-3.24054.13
dotnet-issue-labeler
bot
added
Area-CodeFlow
untriaged
|
@dotnet/roslyn-compiler, This appears to be complaining about a package download (for System.Collections.Immutable) from 8.0.0 to 7.0.0. It looks like you haven't updated since dotnet/roslyn#66561. Any chance we could bump those to 8.0? (I don't know why it should suddenly start failing now, but that seems like a good thing to do regardless. If you don't want to, I can try to look into what changed just before this PR.) |
|
@Cosifne is working on upgrading the packages to 8.0 versions. |
|
Hi @Forgind |
|
Perfect. Thanks! |
…104.13 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.CodeAnalysis.CSharp.CodeStyle , Microsoft.CodeAnalysis.CSharp.Features , Microsoft.CodeAnalysis.CSharp.Workspaces , Microsoft.CodeAnalysis.Workspaces.MSBuild , Microsoft.Net.Compilers.Toolset From Version 4.9.0-3.24053.1 -> To Version 4.9.0-3.24054.13
…104.13 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.CodeAnalysis.CSharp.CodeStyle , Microsoft.CodeAnalysis.CSharp.Features , Microsoft.CodeAnalysis.CSharp.Workspaces , Microsoft.CodeAnalysis.Workspaces.MSBuild , Microsoft.Net.Compilers.Toolset From Version 4.9.0-3.24053.1 -> To Version 4.9.0-3.24054.13
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…104.13 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.CodeAnalysis.CSharp.CodeStyle , Microsoft.CodeAnalysis.CSharp.Features , Microsoft.CodeAnalysis.CSharp.Workspaces , Microsoft.CodeAnalysis.Workspaces.MSBuild , Microsoft.Net.Compilers.Toolset From Version 4.9.0-3.24053.1 -> To Version 4.9.0-3.24054.13
…104.13 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.CodeAnalysis.CSharp.CodeStyle , Microsoft.CodeAnalysis.CSharp.Features , Microsoft.CodeAnalysis.CSharp.Workspaces , Microsoft.CodeAnalysis.Workspaces.MSBuild , Microsoft.Net.Compilers.Toolset From Version 4.9.0-3.24053.1 -> To Version 4.9.0-3.24054.13
…104.13 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.CodeAnalysis.CSharp.CodeStyle , Microsoft.CodeAnalysis.CSharp.Features , Microsoft.CodeAnalysis.CSharp.Workspaces , Microsoft.CodeAnalysis.Workspaces.MSBuild , Microsoft.Net.Compilers.Toolset From Version 4.9.0-3.24053.1 -> To Version 4.9.0-3.24054.13
Avoid a package downgrade warning on SCI and SRM from src\Tasks\Microsoft.NET.Build.Tasks\Microsoft.NET.Build.Tasks.csproj that was happening because the ApiCompat stuff referenced CA.C# and a 4.9 Roslyn update pushes the SCI/SRM references of that to 8.0.0.
dotnet-maestro
bot
requested review from
andriipatsula,
a team,
ericstj and
joperezr
as code owners
ViktorHofer
reviewed
Jan 11, 2024
| @@ -43,6 +43,7 @@ | |||
| <ProjectReference Include="..\Microsoft.DotNet.ApiCompatibility\Microsoft.DotNet.ApiCompatibility.csproj" /> | |||
| <!-- We carry NuGet as part of the package in case the package is used with an older SDKs or with full framework MSBuild. --> | |||
| <PackageReference Include="NuGet.Packaging" PrivateAssets="All" Publish="true"/> | |||
| <PackageReference Include="Microsoft.CodeAnalysis.CSharp" ExcludeAssets="Runtime" PrivateAssets="all" /> | |||
There was a problem hiding this comment.
This package ref only exists for PrivateAssets="all" to stop the flow, right? We should probably add a comment in a follow-up change.
ViktorHofer
reviewed
Jan 11, 2024
| @@ -15,6 +15,8 @@ | |||
| </ItemGroup> | |||
|
|
|||
| <ItemGroup> | |||
| <PackageReference Include="Microsoft.CodeAnalysis.CSharp" ExcludeAssets="Runtime" /> | |||
There was a problem hiding this comment.
Why does this one not have PrivateAssets on it?
There was a problem hiding this comment.
Oh I think maybe it should. IIRC I was hoping that dropping it here would flow to other places and mean we didn't need to change one of the other places, but that didn't work.
ViktorHofer
approved these changes
Jan 11, 2024
dotnet-maestro
bot
deleted the
darc-release/8.0.2xx-3bbb0064-8950-4d07-a8e1-bebb5026d5ba
branch
rainersigwald
added a commit
to rainersigwald/sdk
that referenced
this pull request
Jan 17, 2024
Follow up to changes from dotnet#37801 explaining why.
rainersigwald
added a commit
to rainersigwald/sdk
that referenced
this pull request
Jan 17, 2024
I introduced these in dotnet#37801, but they're overspecified--the PrivateAssets in ApiCompat.Task.csproj is sufficient.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the following dependencies
From https://github.com/dotnet/roslyn