Fix crash with Dispose method with params #75305
Draft
+20
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
untriaged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/2187060
The issue is in
OverloadResolution.AddMemberToCandidateSetwhich may or may not compute a normal result (normalResult) on line 1047, then decides whether to keep the normal or expanded result on line 1079 (PreferExpandedFormOverNormalForm).In the failing scenario, we skip computing a normal result but end up preferring the normal result (which is
default) which then would crash inOverloadResolutionResult.ReportDiagnostics(assertion in debug mode inAssertNone(MemberResolutionKind.None)and throwingUnexpectedValueat line 457 in release mode).The fix is to prefer the expanded result since we didn't compute a normal result.