Reapply "Load analyzers and generators in isolated ALCs in our OOP process" #75233
+1,007
−160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ocess" This reverts commit a59061f.
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
|
Can we get an ETW counter for every time we tear down / rebuild the assembly loader? That is one item we felt would've helped the initial investigation also seems like something we could get David to add as a critical counter for VS insertions. That would block other teams from introducing changes that caused us to reset load context too often. |
We can add counters for this. |
CyrusNajmabadi
force-pushed
the
revertRevert
branch
3 times, most recently
from
4efe410
to
846afc9
Compare
3 tasks
CyrusNajmabadi
force-pushed
the
revertRevert
branch
2 times, most recently
from
42fb81d
to
78612d6
Compare
|
draft while i wait on speedometer |
ToddGrun
reviewed
Sep 30, 2024
src/Workspaces/Core/Portable/Workspace/IsolatedAnalyzerReferenceSet.Core.cs
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit a59061f.
Build: https://devdiv.visualstudio.com/DefaultCollection/DevDiv/_build/results?buildId=10279985&view=results
PR: https://dev.azure.com/devdiv/DevDiv/_git/VS/pullrequest/580882
PR shows no regressions: https://devdiv.visualstudio.com/DevDiv/_apps/hub/ms-vseng.pit-vsengPerf.pit-hub?targetBuild=35325.126.dn-bot.240925.221550.580882&targetBranch=main&targetPerfBuildId=10281500&runGroup=PerfDDRITs64&baselineBuild=35325.104&baselineBranch=main
Build: https://devdiv.visualstudio.com/DefaultCollection/DevDiv/_build/results?buildId=10288337&view=results
PR: https://dev.azure.com/devdiv/DevDiv/_git/VS/pullrequest/581245
Build: https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=10301230&view=results
PR: https://dev.azure.com/devdiv/DevDiv/_git/VS/pullrequest/581245
Build (less directory enums): https://devdiv.visualstudio.com/DefaultCollection/DevDiv/_build/results?buildId=10311649&view=results