Add option for LSP-based auto insert #75224
Conversation
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
| @@ -32,6 +32,8 @@ internal sealed class LspOptionsStorage | |||
|
|
|||
| private static readonly OptionGroup s_codeLensOptionGroup = new(name: "code_lens", description: ""); | |||
|
|
|||
| private static readonly OptionGroup s_onAutoInsertOptionGroup = new(name: "on_auto_insert", description: ""); | |||
There was a problem hiding this comment.
on_auto_insert doesn't sound like a good option group? Is this related to typing?
There was a problem hiding this comment.
Also note I believe the grouping name here would be reflected by vscode in the settings page.
Like inlay hints
So a better group name would be needed.
There was a problem hiding this comment.
"On Auto Insert" is the name of the feature, but it's not option-based in roslyn so the naming has never been an issue. We could change it to Auto Insert, @dibarbet @JoeRobich any thoughts?
There was a problem hiding this comment.
VSCode settings are laid out according to the grouping in the extensions's package.json (Inlay Hints options are under Text Editor). Not really sure what function the OptionGroup plays here.
There was a problem hiding this comment.
I do like "Auto Insert" better.
There was a problem hiding this comment.
Auto insert also seems fine to me. Option group is used as the item after the first arrow. For example for "Dotnet > Inlay Hints: Suppress...", the option group is "Inlay Hints". I think having that be "Auto Insert" would be good.
There was a problem hiding this comment.
VSCode settings are laid out according to the grouping in the extensions's package.json (Inlay Hints options are under Text Editor). Not really sure what function the
OptionGroupplays here.
Yeah it's because the option group name is used in package.json
Auto Insert LGTM
No description provided.