Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use manual recursion for binary patterns #75212

Merged
merged 12 commits into from
Oct 1, 2024

Commits on Sep 23, 2024

  1. Use manual recursion for binary patterns

    Much like binary operators, we can have deeply-nested binary patterns. An example of this is our own IsBuildOnlyDiagnostic, which has ~2500 binary patterns in a single arm, and growing every release. To avoid stack depth issues, I took the same approach we do for binary operators; rewrite recursion to use a manual stack for these cases. Fixes dotnet#73439.
    333fred committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    1af114b View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2024

  1. Configuration menu
    Copy the full SHA
    09dee11 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d372b4b View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2024

  1. Bugfixes

    333fred committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    c5124f3 View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2024

  1. PR feedback.

    333fred committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    1595759 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    22d8e1e View commit details
    Browse the repository at this point in the history
  3. Another while->do conversion

    333fred committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    977493e View commit details
    Browse the repository at this point in the history
  4. Remove unnecessary assert

    333fred committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    fc05825 View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2024

  1. Reduce nested binary expressions to speed up test run, provide DebugV…

    …erifier override as well.
    333fred committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    89a21fc View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4d5160d View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2024

  1. PR feedback.

    333fred committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    4c33987 View commit details
    Browse the repository at this point in the history
  2. Merge remote-tracking branch 'upstream/main' into no-stack-binary-pat…

    …terns
    
    * upstream/main: (267 commits)
      Support long chains of `else if` statements (dotnet#74317)
      Update dependencies from https://github.com/dotnet/source-build-externals build 20240930.2
      Fix the path to the proposal (dotnet#75302)
      Fix TSA tooling (dotnet#75307)
      Clarify the bug template to request a code snippet (dotnet#75306)
      Bump razor for serialization changes (dotnet#75282)
      Disallow declaration of indexers in absence of proper DefaultMemberAttribute. (dotnet#75099)
      stoub
      use ref
      Simpler
      Simplify
      Switch to a threadlocal storage to prevent locks
      add comment
      don't mess with user caret in smart rename
      Update LanguageServer references
      Localized file check-in by OneLocBuild Task: Build definition ID 327: Build ID 2548898
      Use common helper method
      Localized file check-in by OneLocBuild Task: Build definition ID 327: Build ID 2548278
      Field-backed properties: additional tests (dotnet#75283)
      Revert "Updates content exclusion for on-the-fly-docs (dotnet#75172)" (dotnet#75279) (dotnet#75284)
      ...
    333fred committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    040db3a View commit details
    Browse the repository at this point in the history