Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade BCL assembly to 8.0.0 #71444

Merged
merged 17 commits into from
Jan 4, 2024
Merged

Upgrade BCL assembly to 8.0.0 #71444

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
848076b
Upgrade SystemCollectionImmutable, SystemRelectionMetadata and Micros…
Cosifne Jan 2, 2024
fb5a1a7
Upgrade other packages
Cosifne Jan 2, 2024
20ce649
Add reference to Bcl.AsyncInterfaces
Cosifne Jan 2, 2024
24b2014
Copy System.Numerics.Vectors in test, because of the update of refect…
Cosifne Jan 3, 2024
3df1aa6
Try fix the compiler test
Cosifne Jan 3, 2024
b18ab1b
Add the missing source build version in Version.Details.xml
Cosifne Jan 3, 2024
c555956
Fix the analyzer issue
Cosifne Jan 3, 2024
038ab52
Revert "Add the missing source build version in Version.Details.xml"
Cosifne Jan 3, 2024
257fb25
Use darc to update the dependency
Cosifne Jan 3, 2024
0be6aa1
Add versions by darc
Cosifne Jan 3, 2024
6ddff8a
Revert "Add versions by darc"
Cosifne Jan 3, 2024
f4cd26e
Revert the bcl changes
Cosifne Jan 3, 2024
5159608
Revert more
Cosifne Jan 3, 2024
2f402a7
More revert
Cosifne Jan 3, 2024
4ce2da8
Add S.R.M and S.C.I to details.xml
Cosifne Jan 3, 2024
b3b449a
Update source-build-reference-packages version
Cosifne Jan 3, 2024
c024453
Only run two tests in English env
Cosifne Jan 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Compilers/CSharp/Test/Emit/CodeGen/CodeGenReadOnlySpanConstructionTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1586,7 +1586,7 @@ .locals init (System.ReadOnlySpan<byte> V_0, //s1
");
}

[Fact]
[ConditionalFact(typeof(IsEnglishLocal))]
Copy link
Member Author

@Cosifne Cosifne Jan 4, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failed in Spanish VM
image
Loosk like it is asserting Error message, and the message is localized now.
So I changed this to English only

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Talked to Compiler folks offline and verifed this is OK

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Cosifne

Talked to Compiler folks offline and verifed this is OK

I think we should open an issue for the test infrastructure. It should make sure that verification errors are obtained in English. Then this change should be reverted

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opened #71509.

public void MultipleArrays_InPlaceAndUsed()
{
string csharp = @$"
Expand Down
2 changes: 1 addition & 1 deletion src/Compilers/CSharp/Test/Emit/CodeGen/CodeGenTryFinally.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3760,7 +3760,7 @@ .maxstack 1
");
}

[Fact]
[ConditionalFact(typeof(IsEnglishLocal))]
[WorkItem("https://github.com/dotnet/roslyn/issues/67494")]
public void WhenWithAlwaysThrowingExpression_01()
{
Expand Down