Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ResxSourceGenerator: Added XML comment summary to the generated classes and properties to avoid warning CS1591 if they are public #7366

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

uo1
Copy link

@uo1 uo1 commented Jul 30, 2024

If the classes generated by the ResxSourceGenerator are public, the warning CS1591 has been emitted, since the XML comments were missing.

@uo1 uo1 marked this pull request as ready for review July 30, 2024 14:35
@uo1 uo1 requested a review from a team as a code owner July 30, 2024 14:35
Copy link

codecov bot commented Jul 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.49%. Comparing base (81d9b5d) to head (21946bf).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7366   +/-   ##
=======================================
  Coverage   96.49%   96.49%           
=======================================
  Files        1443     1443           
  Lines      345799   345805    +6     
  Branches    11374    11374           
=======================================
+ Hits       333671   333679    +8     
+ Misses       9244     9243    -1     
+ Partials     2884     2883    -1     

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant