Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document where exported function is imported #9535

Merged
merged 1 commit into from
Sep 23, 2024
Merged

Document where exported function is imported #9535

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions ...ectSystem.Managed/ProjectSystem/LanguageServices/FSharp/FSharpCommandLineParserService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,17 +73,19 @@ public BuildOptions Parse(IEnumerable<string> arguments, string baseDirectory)
}

return new FSharpBuildOptions(
sourceFiles: sourceFiles.ToImmutableArray(),
additionalFiles: ImmutableArray<CommandLineSourceFile>.Empty,
metadataReferences: metadataReferences.ToImmutableArray(),
analyzerReferences: ImmutableArray<CommandLineAnalyzerReference>.Empty,
compileOptions: commandLineOptions.ToImmutableArray());
sourceFiles: sourceFiles.ToImmutableArray(),
additionalFiles: [],
metadataReferences: metadataReferences.ToImmutableArray(),
analyzerReferences: [],
compileOptions: commandLineOptions.ToImmutableArray());
}

[Export]
[AppliesTo(ProjectCapability.FSharp)]
public void HandleCommandLineNotifications(string binPath, BuildOptions added, BuildOptions removed)
{
// NOTE this method is imported in CommandLineNotificationHandler as an Action<string?, BuildOptions, BuildOptions>

if (added is FSharpBuildOptions fscAdded)
{
foreach (Action<string, ImmutableArray<CommandLineSourceFile>, ImmutableArray<CommandLineReference>, ImmutableArray<string>> handler in _handlers)
Expand Down
Loading