Pass legacy root node ProjectTreeFlags #9123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a regression from the dependency tree rewrite. Implementations of the legacy extension point `IProjectDependenciesSubTreeProvider.CreateRootDependencyNode` return an `IDependencyModel` holding various values to be applied to the group's node. One such value is `IDependencyModel.Flags` which should be applied to the group node. This change fixes that.
drewnoakes
added
the
Feature-Dependency-Node
|
Web projects showing NPM packages are the most common use case for this extension point. Thanks to Pranav Senthilnathan for reporting this issue. |
melytc
approved these changes
Jun 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a regression from the dependency tree rewrite in #9008.
Implementations of the legacy extension point
IProjectDependenciesSubTreeProvider.CreateRootDependencyNode()return anIDependencyModelholding various values to be applied to the group's node. One such value isIDependencyModel.Flagswhich should be applied to the group node. This change fixes that.Microsoft Reviewers: Open in CodeFlow