Adds unified settings with migration #9108

adamint · 2023-06-21T20:51:47Z

For some reason, the unified settings provider doesn't pick up UnifiedSettings folder if it is located in our MS.VS.Editors package. The current settings are located in that package, but in this PR are relocated to the ManagedProjectSystem package.

There is no projectsAndSolutions string, as one already exists (and we are warned about duplicates). I've manually confirmed this works.

Microsoft Reviewers: Open in CodeFlow

adamint · 2023-06-21T20:52:35Z

setup/Microsoft.VisualStudio.ProjectSystem.Managed.CommonFiles/CommonFiles.swr

@@ -657,3 +657,6 @@ folder "InstallDir:MSBuild\Microsoft\VisualStudio\Managed\zh-Hant"
 file source="$(VisualStudioXamlRulesDir)zh-Hant\ResolvedProjectReference.xaml"
 file source="$(VisualStudioXamlRulesDir)zh-Hant\ResolvedSdkReference.xaml"
 file source="$(VisualStudioXamlRulesDir)zh-Hant\SdkReference.xaml"
+
+ folder "Extensions\Microsoft\ManagedProjectSystem\UnifiedSettings"


We're required to place the settings in this specific place: ExtensionRoot\UnifiedSettings*.registration.json

smitpatel · 2023-06-22T07:26:06Z

setup/Microsoft.VisualStudio.ProjectSystem.Managed.CommonFiles/CommonFiles.swr

@@ -657,3 +657,6 @@ folder "InstallDir:MSBuild\Microsoft\VisualStudio\Managed\zh-Hant"
 file source="$(VisualStudioXamlRulesDir)zh-Hant\ResolvedProjectReference.xaml"
 file source="$(VisualStudioXamlRulesDir)zh-Hant\ResolvedSdkReference.xaml"
 file source="$(VisualStudioXamlRulesDir)zh-Hant\SdkReference.xaml"
+
+ folder "Extensions\Microsoft\ManagedProjectSystem\UnifiedSettings"
+ file source="$(VisualStudioExtensionSetupDir)\ProjectSystemSetup\UnifiedSettings\ManagedProjectSystem.registration.json"


Could we pick this up from output rather than the source project? The file has CopyToOutputDirectory so it would be copied somewhere.

Or just don't copy it to the output directory.

It's a static file, so it's not necessary to pick up from output. @tmeschter removed copying to output dir.

drewnoakes · 2023-06-22T10:31:41Z

What's the developer experience like with unified settings? If you make a change to that JSON file and press F5, does it apply immediately?

Can we create a new .resx file for the strings used in settings?

src/Microsoft.VisualStudio.ProjectSystem.Managed.VS/VSPackage.resx

drewnoakes · 2023-06-22T10:34:56Z

What's the "migration" referred to in the PR title?

drewnoakes · 2023-06-22T10:37:31Z

Would be good to confirm what's expected around capitalisation. My understanding is that we tend not to use All Caps In Titles Anymore. Instead we use sentence casing with only the first word in caps, unless its a proper noun. You can see this in our documentation on learn.microsoft.com, for example. We were careful to apply this throughout the new Project Properties UI, and a lot of other VS UI does the same, such as codefix labels and so forth.

The old UI capitalised all words, but that's a really old style UI. I don't think it suits the new UI.

tmeschter · 2023-06-22T16:50:43Z

setup/ProjectSystemSetup/UnifiedSettings/ManagedProjectSystem.registration.json

+ "path": "ManagedProjectSystem\\FastUpToDateCheckEnabled"
+ }
+ }
+ }


"Migration" implies that the unified settings will move the current value of the setting as specified in the path and store it somewhere else going forward. Is that accurate? Any concerns about round-tripping the settings between VS installs using unified settings and those that don't? Or am I misunderstanding what this means?

No concerns about round-tripping, as this migration field takes care of converting legacy <-> unified settings location.
That's correct, they will be stored in a new location determined by the unified settings manager

Are settings stored in both locations then, at least for now? I wonder how conflicts are resolved.

tmeschter · 2023-06-22T16:51:09Z

setup/ProjectSystemSetup/UnifiedSettings/ManagedProjectSystem.registration.json

+ "properties": {
+ "projectsAndSolutions.sdkStyleProjects.fastUpToDateCheck.enabled": {
+ "type": "boolean",
+ "title": "@Setting_FastUpToDateCheck_Enabled_Title;{860A27C0-B665-47F3-BC12-637E16A1050A}",


The GUID identifies the VS package?

Correct. I'd comment the json, if it were possible

adamint · 2023-06-22T19:05:06Z

What's the "migration" referred to in the PR title?

See #9108 (comment)

adamint · 2023-06-22T19:10:31Z

Would be good to confirm what's expected around capitalisation. My understanding is that we tend not to use All Caps In Titles Anymore. Instead we use sentence casing with only the first word in caps, unless its a proper noun. You can see this in our documentation on learn.microsoft.com, for example. We were careful to apply this throughout the new Project Properties UI, and a lot of other VS UI does the same, such as codefix labels and so forth.

The old UI capitalised all words, but that's a really old style UI. I don't think it suits the new UI.

Changed.

What's the developer experience like with unified settings? If you make a change to that JSON file and press F5, does it apply immediately?

No, and it currently has much room for improvement. I've been in touch with the Shell team, and they are working on a better developer experience, but we are one of the dogfooders here. You have to unzip the vsix and manually replace the installed package in the VS install dir. They do not pick up experimental instance extension data.

Can we create a new .resx file for the strings used in settings?

No, we cannot. I asked this question directly to the team. It must be in the VS package resx

…s xaml files, fix package content test

tests/Microsoft.VisualStudio.ProjectSystem.Managed.VS.UnitTests/Setup/SwrTests.cs

…s/Setup/SwrTests.cs Co-authored-by: Melissa Treviño <[email protected]>

… into dev/adamint/unified-settings-ui

This reverts commit 44565c3.

This reverts commit 44565c3. Co-authored-by: Adam Ratzman <[email protected]>

This reverts commit ad9167e.

…otnet#9129)" This reverts commit 2eca631.

#9155) This reverts commit 2eca631.

adamint added 2 commits June 20, 2023 23:24

Add Settings for project system

4e7ee44

Was missing semicolon in strings....

9906849

adamint requested a review from a team as a code owner June 21, 2023 20:51

ghost added the Feature-Tools-Options-UI "Tools | Options" pages in VS label Jun 21, 2023

adamint commented Jun 21, 2023

View reviewed changes

smitpatel reviewed Jun 22, 2023

View reviewed changes

drewnoakes reviewed Jun 22, 2023

View reviewed changes

src/Microsoft.VisualStudio.ProjectSystem.Managed.VS/VSPackage.resx Outdated Show resolved Hide resolved

haileymck approved these changes Jun 22, 2023

View reviewed changes

tmeschter reviewed Jun 22, 2023

View reviewed changes

adamint added 2 commits June 22, 2023 12:12

Strings reflect current guidelines, don't copy settings file to output

7d08f19

Rename filePrefix/folderPrefix to _xaml.. because the test only cover…

e75ba85

…s xaml files, fix package content test

melytc reviewed Jun 22, 2023

View reviewed changes

tests/Microsoft.VisualStudio.ProjectSystem.Managed.VS.UnitTests/Setup/SwrTests.cs Show resolved Hide resolved

adamint and others added 4 commits June 22, 2023 14:10

Update tests/Microsoft.VisualStudio.ProjectSystem.Managed.VS.UnitTest…

f3d7fd8

…s/Setup/SwrTests.cs Co-authored-by: Melissa Treviño <[email protected]>

Ignore settings manifest file in CommonFiles test

89d4118

Merge remote-tracking branch 'origin/dev/adamint/unified-settings-ui'…

2df6d1b

… into dev/adamint/unified-settings-ui

Remove settings file from packaging tests

e46f762

adamint merged commit 44565c3 into dotnet:main Jun 26, 2023
5 checks passed

ghost added this to the 17.7 milestone Jun 26, 2023

adamint pushed a commit to adamint/project-system that referenced this pull request Jun 27, 2023

Revert "Adds unified settings with migration (dotnet#9108)"

ad9167e

This reverts commit 44565c3.

adamint added a commit that referenced this pull request Jun 28, 2023

Revert "Adds unified settings with migration (#9108)" (#9129)

2eca631

This reverts commit 44565c3. Co-authored-by: Adam Ratzman <[email protected]>

adamint pushed a commit to adamint/project-system that referenced this pull request Jul 5, 2023

Revert "Revert "Adds unified settings with migration (dotnet#9108)""

c1d6987

This reverts commit ad9167e.

adamint added a commit to adamint/project-system that referenced this pull request Jul 11, 2023

Revert "Revert "Adds unified settings with migration (dotnet#9108)" (d…

fe96c40

…otnet#9129)" This reverts commit 2eca631.

adamint added a commit that referenced this pull request Jul 12, 2023

Revert "Revert "Adds unified settings with migration (#9108)" (#9129)" (

4b2859a

#9155) This reverts commit 2eca631.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adds unified settings with migration #9108

Adds unified settings with migration #9108

adamint commented Jun 21, 2023 •

edited by ghost

Loading

adamint Jun 21, 2023

smitpatel Jun 22, 2023

tmeschter Jun 22, 2023

adamint Jun 22, 2023

drewnoakes commented Jun 22, 2023

drewnoakes commented Jun 22, 2023

drewnoakes commented Jun 22, 2023

tmeschter Jun 22, 2023

adamint Jun 22, 2023

drewnoakes Jun 23, 2023

tmeschter Jun 22, 2023

adamint Jun 22, 2023 •

edited

Loading

adamint commented Jun 22, 2023

adamint commented Jun 22, 2023 •

edited

Loading

Adds unified settings with migration #9108

Adds unified settings with migration #9108

Conversation

adamint commented Jun 21, 2023 • edited by ghost Loading

Microsoft Reviewers: Open in CodeFlow

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

drewnoakes commented Jun 22, 2023

drewnoakes commented Jun 22, 2023

drewnoakes commented Jun 22, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

adamint Jun 22, 2023 • edited Loading

Choose a reason for hiding this comment

adamint commented Jun 22, 2023

adamint commented Jun 22, 2023 • edited Loading

adamint commented Jun 21, 2023 •

edited by ghost

Loading

adamint Jun 22, 2023 •

edited

Loading

adamint commented Jun 22, 2023 •

edited

Loading