Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synchronise language service project updates #8895

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

drewnoakes
Copy link
Member

@drewnoakes drewnoakes commented Mar 3, 2023

Ensures a workspace will not be disposed during an update by wrapping the update in ExecuteUnderLockAsync.

Diff looks worse than it is. Recommend viewing without white space changes.

Microsoft Reviewers: Open in CodeFlow

@drewnoakes drewnoakes added the Feature-Language-Service Populating the Roslyn workspace with references, source files, analyzers, etc label Mar 3, 2023
@drewnoakes drewnoakes added this to the 17.6 milestone Mar 3, 2023
@drewnoakes drewnoakes requested a review from a team as a code owner March 3, 2023 03:56
@drewnoakes drewnoakes force-pushed the workspace-update-synchronisation branch from 78eadfe to 411953b Compare March 3, 2023 04:02
Copy link
Contributor

@tmeschter tmeschter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I think we need to make the same change to the WriteAsync methods.

@jasonmalinowski
Copy link
Member

@drewnoakes @tmeschter So this meant you were potentially updating a project while it was being disposed at the same time? I wonder if that explains a bunch of bugs I've been seeing that I haven't been able to track down....

@tmeschter
Copy link
Contributor

@jasonmalinowski Possibly. More likely if the issues you were seeing involved ObjectDisposedExceptions.

@drewnoakes
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@MiYanni
Copy link
Member

MiYanni commented Mar 7, 2023

@drewnoakes We've been hitting concurrency issues with the agent pool all day. If you look at the graph here and add the currently running jobs + queued jobs, it'll be around 820, which is the max for the agent pool. We'll just have to wait.
https://dev.azure.com/dnceng-public/public/_settings/agentqueues?queueId=13&view=analytics

@jasonmalinowski
Copy link
Member

@jasonmalinowski Possibly. More likely if the issues you were seeing involved ObjectDisposedExceptions.

Nothing specifically with object disposed exceptions, but we were seeing bugs where we'd potentially try creating references to projects that are missing, or things like that. If it's possible you were removing a project from the workspace and also adding/removing output paths for it at the same time, we might have gotten into those bad states.

@drewnoakes
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Ensures a workspace will not be disposed during an update by wrapping the update in `ExecuteUnderLockAsync`.
@drewnoakes drewnoakes force-pushed the workspace-update-synchronisation branch from 6746fff to 259709b Compare March 9, 2023 09:44
@drewnoakes
Copy link
Member Author

@drewnoakes We've been hitting concurrency issues with the agent pool all day. If you look at the graph here and add the currently running jobs + queued jobs, it'll be around 820, which is the max for the agent pool. We'll just have to wait. https://dev.azure.com/dnceng-public/public/_settings/agentqueues?queueId=13&view=analytics

I think the failure is actually related to this PR somehow. Other PRs are building. I will investigate later as it's late here now.

FYI @tmeschter

@tmeschter
Copy link
Contributor

@drewnoakes A quick review of the build output does look like it could be hanging in the unit test run. :-(

@drewnoakes drewnoakes modified the milestones: 17.6, 17.7 Apr 13, 2023
@drewnoakes drewnoakes modified the milestones: 17.7, 17.8 Jul 13, 2023
@drewnoakes drewnoakes removed this from the 17.8 milestone Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature-Language-Service Populating the Roslyn workspace with references, source files, analyzers, etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants