Reseting thumb image #26085
Open
Reseting thumb image #26085
+101
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there @kubaflo! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
PureWeen
requested changes
Nov 24, 2024
| @@ -63,6 +62,11 @@ public static async Task UpdateThumbImageSourceAsync(this SeekBar seekBar, ISlid | |||
| if (seekBar.IsAlive() && thumbDrawable != null) | |||
| seekBar.SetThumb(thumbDrawable); | |||
| } | |||
| else if (slider.Handler is SliderHandler sliderHandler) | |||
| { | |||
| seekBar.SetThumb(sliderHandler.defaultThumbDrawable); | |||
There was a problem hiding this comment.
Can we load the default thumb drawable from the android resources? I'm sure the default drawable here can probably get pulled from the android resources
There was a problem hiding this comment.
Yea, I was initially trying with this: `seekBar.SetThumb(context.GetDrawable(Resource.Drawable.abc_seekbar_thumb_material)), but I couldn't make it revert back to a default color, but I figured it out
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
jsuarezruiz
requested changes
Nov 25, 2024
| App.WaitForElement("ChangeThumbImageSourceButton"); | ||
| App.Click("ChangeThumbImageSourceButton"); | ||
| App.Click("ResetThumbImageSourceButton"); | ||
| VerifyScreenshot(); |
There was a problem hiding this comment.
Snapshots available in the latest build:
Could you commit the images?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues Fixed
Fixes #25939
Screen.Recording.2024-11-24.at.14.41.33.mov
Screen.Recording.2024-11-24.at.14.33.32.mov