Remove Legacy Gallery from SLNs #26068
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfversluis
approved these changes
Nov 22, 2024
jsuarezruiz
requested changes
Nov 22, 2024
There was a problem hiding this comment.
I think also need to update scripts removing the legacy gallery. For example:
maui/eng/devices/devices-shared.cake
Line 16 in f642447
or
Line 236 in f642447
And from the pipelines:
maui/eng/pipelines/ui-tests.yml
Line 165 in f642447
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
We're not longer using the Legacy Galleries so let's remove them from our SLNs. This should help load and build times a bit.
I moved the CG SLNF to a full SLN just in case we want to run the Legacy CGs at a later point in time. Ideally we will just delete all this code for net10 or later this year