-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix grid not getting invalidated when changing the Height/Width of Row/ColumnDefinitions declared with the short syntax #26046
base: main
Are you sure you want to change the base?
Conversation
Ooops last time I checked no one was assigned to the issue... sorry @sheiksyedm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could include an UITest?
@jsuarezruiz is this alright? If yes I'd need screenshots from CI |
Might not need a uitest, could be a unit test. I wonder if some of the existing test check for the update and can be copied for this scenario. |
@mattleibow I guess I could do something similar to this but additionaly change row/column size with maui/src/Core/tests/UnitTests/Layouts/GridLayoutManagerTests.cs Lines 207 to 229 in 9416968
|
Description of Change
Issues Fixed
Fixes #25983
After change
2024-11-22.05-21-30.mp4