Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nested Flex Layouts #25036

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Nested Flex Layouts #25036

wants to merge 4 commits into from

Conversation

kubaflo
Copy link
Contributor

@kubaflo kubaflo commented Oct 1, 2024

Description of Change

I'm considering whether this change might have any unforeseen implications. At present, it seems safe because flex layouts nested inside other flex layouts aren't functioning as expected at all and this change only affects this situation

Issues Fixed

Fixes: #24653
Fixes: #20461

Before After

@kubaflo kubaflo requested a review from a team as a code owner October 1, 2024 18:36
@dotnet-policy-service dotnet-policy-service bot added the community ✨ Community Contribution label Oct 1, 2024
Copy link
Contributor

Hey there @kubaflo! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@jfversluis
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@MartyIX
Copy link
Contributor

MartyIX commented Oct 5, 2024

btw: Windows image looks very different than others. Just to be clear, is that a bug or not?

@kubaflo
Copy link
Contributor Author

kubaflo commented Oct 5, 2024

btw: Windows image looks very different than others. Just to be clear, is that a bug or not?

Hmm I’m not sure. Could you maybe have a look at this please?

@MartyIX
Copy link
Contributor

MartyIX commented Oct 5, 2024

I can see:

image

and without your first commit (2a43d95) it looks like this:

image

@kubaflo
Copy link
Contributor Author

kubaflo commented Oct 5, 2024

I can see:

image

and without your first commit (2a43d95) it looks like this:

image

I think without my commit it looks very wrong. On iOS and Android, everything looks as expected, I think Windows might need some adjustment, but I don't have a Windows machine to work on it. Thanks for sending screenshots!

I think only this part doesn't work on Windows, but maybe it is how it is supposed to be.
Screenshot 2024-10-05 at 17 05 43

@jsuarezruiz
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@jsuarezruiz
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Image Button in a nested flex layout not rendering Nested FlexLayouts don't show BackgroundColor
4 participants