[android] update .aotprofile for .NET 9 RC 2
#25035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I recorded these with the `35.0.0-rc.2.145` Android workload as there was one change that disables `$(AndroidEnableMarshalMethods)` that impacts `.aotprofile` files: * dotnet/android@afb5f7e With this change in place, managed C# methods like these will reappear in the profile: bool Android.Runtime.AndroidTypeManager:FastRegisterNativeMembers (Java.Interop.JniType,System.Type,System.ReadOnlySpan`1<char>) ... bool Android.Runtime.JNINativeWrapper:Wrap_JniMarshal_PPJ_Z (_JniMarshal_PPJ_Z,intptr,intptr,long) bool Android.Runtime.JNINativeWrapper:Wrap_JniMarshal_PPL_Z (_JniMarshal_PPL_Z,intptr,intptr,intptr) bool Android.Runtime.JNINativeWrapper:Wrap_JniMarshal_PPLLJ_Z (_JniMarshal_PPLLJ_Z,intptr,intptr,intptr,intptr,long) ... System.Delegate Android.App.Activity:GetOnActivityResult_IILandroid_content_Intent_Handler () System.Delegate Android.App.Activity:GetOnBackPressedHandler () In the future, we hope to bring back `$(AndroidEnableMarshalMethods)` once the known issues are worked out. Measuring the new profile on a Pixel 7 Pro, an average of 10 runs of the `dotnet new maui` project template: Before: Average(ms): 475.2 Std Err(ms): 3.96316371938716 Std Dev(ms): 12.5326240934078 After: Average(ms): 447.1 Std Err(ms): 1.75404294892305 Std Dev(ms): 5.54677083235522 So, this change likely avoids some startup regression on Android, as the C# methods that run on startup when `AndroidEnableMarshalMethods=false` are now AOT-compiled. I also added `-bl` to the `README.md`, as I thought that was useful.
|
/backport to release/9.0.1xx-rc2 |
|
Started backporting to release/9.0.1xx-rc2: https://github.com/dotnet/maui/actions/runs/11134020867 |
samhouts
added
the
fixed-in-net9.0-nightly
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recorded these with the
35.0.0-rc.2.145Android workload as there was one change that disables$(AndroidEnableMarshalMethods)that impacts.aotprofilefiles:With this change in place, managed C# methods like these will reappear in the profile:
In the future, we hope to bring back
$(AndroidEnableMarshalMethods)once the known issues are worked out.Measuring the new profile on a Pixel 7 Pro, an average of 10 runs of the
dotnet new mauiproject template:So, this change likely avoids some startup regression on Android, as the C# methods that run on startup when
AndroidEnableMarshalMethods=falseare now AOT-compiled.I also added
-blto theREADME.md, as I thought that was useful.