You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Android, the BottomNavigationView initially has a ColorDrawable with a white background, which is the default color during its creation.
Later, the BottomNavigationView background is changed to a ColorChangeRevealDrawable with an animation, transitioning to the color specified by IShellAppearanceElement.EffectiveTabBarBackgroundColor.
Since the previous background color (white) differs from the current color (black), the animation displays a transition from white to black when switching pages.
Description of Change:
To resolve this issue, the IShellAppearanceElement.EffectiveTabBarBackgroundColor is applied to the background of the BottomNavigationView immediately after its creation.
This ensures that no animation is triggered later, as the previous background color (black) and the current color (black) remain the same.
@PureWeen The test case failing seems to be in Windows, even though the fix is specifically added for android.
Could you please check this once? If not can we try triggering the CI once.
@PureWeen The test case failing seems to be in Windows, even though the fix is specifically added for android. Could you please check this once? If not can we try triggering the CI once.
Test failures on this one seem accurate
@PureWeen The test case failing seems to be in Windows, even though the fix is specifically added for android. Could you please check this once? If not can we try triggering the CI once.
The failure I'm referring to is that both API levels of the Android aren't running to completion
It looks like the changes here are causing the device tests on android to crash.
If you download the logcat file from the device test runs you should be able to see a crash in there that will need to be resolved
@PureWeen The test case failing seems to be in Windows, even though the fix is specifically added for android. Could you please check this once? If not can we try triggering the CI once.
Test failures on this one seem accurate
@PureWeen The test case failing seems to be in Windows, even though the fix is specifically added for android. Could you please check this once? If not can we try triggering the CI once.
The failure I'm referring to is that both API levels of the Android aren't running to completion
It looks like the changes here are causing the device tests on android to crash. If you download the logcat file from the device test runs you should be able to see a crash in there that will need to be resolved
• I identified the cause of the crash during device testing on Android API 23.
• The issue arises because the EffectiveTabBarBackgroundColor property is null in this API version.
• To resolve this, I applied the DefaultBottomNavigationViewBackgroundColor as a fallback to ensure the background color is set properly.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
jsuarezruiz
added
platform/android 🤖
area-controls-shell
github-actions
bot
force-pushed
the
fix-16522
branch
from
Root Cause:
Description of Change:
Tested the behaviour in the following platforms.
Reference
N/A
Issues Fixed
Fixes #16522
Screenshots