Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Measure invalidation performance and fixes #24532

Closed
wants to merge 16 commits into from
Closed

Measure invalidation performance and fixes #24532

wants to merge 16 commits into from

Commits on Sep 17, 2024

  1. Improve measure invalidation and legacy Layout(s) performance 

    - Do not bubble up `MeasureInvalidated` on pages
- Invoke `MeasureInvalidated` just once when `BindingContext` is changing
- Do not synchronously measure/arrange children on legacy layout upon child measure invalidated: simply wait for the next native layout pass
    @albyrock87
    albyrock87 committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    5ed7827 View commit details
    Browse the repository at this point in the history

  2. Add a UI test to log rendering performance

    @albyrock87
    albyrock87 committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    c62e9c0 View commit details
    Browse the repository at this point in the history

  3. Remove ApplyBindings and reduce OnChildMeasureInvalidatedInternal… 

    … switch branches
    @albyrock87
    albyrock87 committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    d36434f View commit details
    Browse the repository at this point in the history

  4. Update Issue24532.xaml.cs

    @PureWeen @albyrock87
    PureWeen authored and albyrock87 committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    90319f0 View commit details
    Browse the repository at this point in the history

  5. Account for view Constraint and propagate InvalidationTrigger on … 

    …parent correctly
    @albyrock87
    albyrock87 committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    ce0e9cd View commit details
    Browse the repository at this point in the history

  6. Now that we are not invalidating manually each LegacyLayout, we hav… 

    …e to invalidate parent chain through the platform view on `ScrollView` (iOS)
    @albyrock87
    albyrock87 committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    54525eb View commit details
    Browse the repository at this point in the history

  7. Sync behavior on Page

    @albyrock87
    albyrock87 committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    7705332 View commit details
    Browse the repository at this point in the history

  8. Removes old perf test

    @albyrock87
    albyrock87 committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    961d38f View commit details
    Browse the repository at this point in the history

  9. Adds a rendering performance test

    @albyrock87
    albyrock87 committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    d20d55e View commit details
    Browse the repository at this point in the history

  10. Additional refactor

    @albyrock87
    albyrock87 committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    9ffd4d7 View commit details
    Browse the repository at this point in the history

  11. Removes performance test

    @albyrock87
    albyrock87 committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    a585de8 View commit details
    Browse the repository at this point in the history

  12. Remove old comments

    @albyrock87
    albyrock87 committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    5bb3b5b View commit details
    Browse the repository at this point in the history

  13. Remove useless branches and fix order of invocation

    @albyrock87
    albyrock87 committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    5dd574a View commit details
    Browse the repository at this point in the history

  14. Fix broken device test

    @albyrock87
    albyrock87 committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    1712761 View commit details
    Browse the repository at this point in the history

  15. Third tentative to make things right

    @albyrock87
    albyrock87 committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    b9e69c7 View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2024

  1. Cleanup and fix enhanced ViewTests broken device test

    @albyrock87
    albyrock87 committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    3fcb4fb View commit details
    Browse the repository at this point in the history