-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[net9.0] Merge main to net9.0 #24523
Commits on Aug 27, 2024
-
[iOS] Bugfix/22469 ios label crash (#22487)
* Add UI test * Update RecalculateSpanPositions * Update UI test to make it crash regardless of testing iOS device * Always use original textContainer * Revert "Always use original textContainer" This reverts commit f0bf613. * Always use original text container * change the test to the correct issue and delete extra files that may have happened in the rebase * remove local uitest changes * remove linq and change back to correct issue number --------- Co-authored-by: tj-devel709 <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for d93e48d - Browse repository at this point
Copy the full SHA d93e48dView commit details -
[Testing] CollectionViewInfiniteScroll Conversion to UI Test (#24411)
* Initial Commit * Solved issue of automation id not picking up * Renamed files, set correct issue text * Removed unnecessary variables, comments * Disabled test for Catalyst as well * Fixed previous * Added MovedToAppium tag for original test
Configuration menu - View commit details
-
Copy full SHA for 033b01a - Browse repository at this point
Copy the full SHA 033b01aView commit details -
[resizetizer] fix a build performance issue (#24453)
I was testing a .NET MAUI project template in Visual Studio on a Windows DevBox, and I noticed a target taking *a lot* of time: ResizetizeImages 1.302s Skipping target "ResizetizeImages" because all output files are up-to-date with respect to the input files. This is happening on incremental builds with no changes. This is even worse for Android, because it runs twice: one for build and one for deploy. The `ResizetizeImages` MSBuild target is *skipped*, why is it slow?!? To "debug" this, I added this ugly, one-liner between every `<ItemGroup>` in the target: <ItemGroup> </ItemGroup><PropertyGroup><_Time>$([System.DateTime]::Now.ToString('THH:mm:ss.fffffffZ'))</_Time></PropertyGroup><ItemGroup> <_MauiImageToProcess Include="@(MauiImage)" Exclude="$(DefaultItemExcludes)" /> </ItemGroup><PropertyGroup><_Time>$([System.DateTime]::Now.ToString('THH:mm:ss.fffffffZ'))</_Time></PropertyGroup><ItemGroup> <!-- more item groups --> </ItemGroup><PropertyGroup><_Time>$([System.DateTime]::Now.ToString('THH:mm:ss.fffffffZ'))</_Time></PropertyGroup><ItemGroup> </ItemGroup> (I found the `/profileevaluation` switch didn't help me here) This led me to find the problematic line, is this one: <_MauiImageToProcess Include="@(MauiImage)" Exclude="$(DefaultItemExcludes)" /> Where `$(DefaultItemExcludes)` is: DefaultItemExcludes = ;bin\Debug\/**;obj\Debug\/**;bin\/**;obj\/**;**/*.user;**/*.*proj;**/*.sln;**/*.vssscc;**/.DS_Store This was introduced in a92fd1d to fix `.DS_Store` files in the folder: <MauiImage Include="Resources\Images\*" /> (This is in the .NET MAUI project template). What is happening is: * MSBuild expands these 9 wildcards to a lot of files * MSBuild now has to filter out the files that are in `@(MauiImage)` If I simply reduce this to: <_MauiImageToProcess Include="@(MauiImage)" Exclude="**/.DS_Store" /> It still takes 177ms after this change, because MSBuild has to do a recursive file listing of the current project. So, we can do better. We can use `Condition` instead: <_MauiImageToProcess Include="@(MauiImage)" Condition=" '%(FileName)%(Extension)' != '.DS_Store' " /> After these changes, the target now takes: ResizetizeImages 6ms I can't think of what this would break, as I don't think any of these files are in `Resources\Images`: DefaultItemExcludes = ;bin\Debug\/**;obj\Debug\/**;bin\/**;obj\/**;**/*.user;**/*.*proj;**/*.sln;**/*.vssscc;**/.DS_Store The only problem I can think of would be if someone sets `$(DefaultItemExcludes)` to a custom value, and I think saving the build time is worth it.
Configuration menu - View commit details
-
Copy full SHA for 1b00140 - Browse repository at this point
Copy the full SHA 1b00140View commit details -
Configuration menu - View commit details
-
Copy full SHA for 588eece - Browse repository at this point
Copy the full SHA 588eeceView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0ec9b63 - Browse repository at this point
Copy the full SHA 0ec9b63View commit details
Commits on Aug 28, 2024
-
23152 - Moving one item between groups of a Grouped CollectionView re…
…sults in the temporary fading out of two items instead of one on Android (#24461)
Configuration menu - View commit details
-
Copy full SHA for 36994dc - Browse repository at this point
Copy the full SHA 36994dcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 443afb7 - Browse repository at this point
Copy the full SHA 443afb7View commit details -
[Android] Fix for the CarouselView doesn't scroll to the right Positi…
…on after changing the ItemSource with Loop enabled. (#24431) * Added the fix for the Carousel position issue * Optimized the fix. * Removed the unwanted codes. * Modified the test script. * Added the Windows failure tag. --------- Co-authored-by: AhamedAliNishad <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 84a6544 - Browse repository at this point
Copy the full SHA 84a6544View commit details -
Remove code from iOS that short circuits propagation (#24477)
* Remove code from iOS that short circuits propagation * - fix
Configuration menu - View commit details
-
Copy full SHA for 944d860 - Browse repository at this point
Copy the full SHA 944d860View commit details
Commits on Aug 29, 2024
-
Configuration menu - View commit details
-
Copy full SHA for d49c5df - Browse repository at this point
Copy the full SHA d49c5dfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5aae18c - Browse repository at this point
Copy the full SHA 5aae18cView commit details -
Merge branch 'main' into merge_main_net0
# Conflicts: # src/Core/src/PublicAPI/net-maccatalyst/PublicAPI.Unshipped.txt
Configuration menu - View commit details
-
Copy full SHA for ef4ef62 - Browse repository at this point
Copy the full SHA ef4ef62View commit details
Commits on Aug 30, 2024
-
Configuration menu - View commit details
-
Copy full SHA for e4ac658 - Browse repository at this point
Copy the full SHA e4ac658View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6a207d2 - Browse repository at this point
Copy the full SHA 6a207d2View commit details -
Fix for FlexLayout padding issue (#24195)
* Fix-15991- Fixed the padding issue on FlexLayout by add the padding calculation in the Measure and ArrangeChildren method(). * added UITest - 15991 * Fix-15991- Output images added for android and iOS. * Fix-15991-Updated test method name. * Fix-15991-Updated the test image based on the Test method name. * Fix-15991-Updated test method with scrollView automationID. * Fix-15991-Output image added for windows. * Fix-15991-Added Unit test case and removed UI testcase. * Fix-15991-Modified Unit TestCase FlexLayout. * Fix-15991-Modified Unit TestCase for FlexLayout.
Configuration menu - View commit details
-
Copy full SHA for ddab6b3 - Browse repository at this point
Copy the full SHA ddab6b3View commit details -
[Android] SecureStorage: Rework logic to delete shared prefs when key…
… is corrupt (#23850) * Rework logic to delete shared prefs when key is corrupt Sometimes encrypted shared preferences can become unusable on android when backed up data gets migrated between different devices (and possibly in other scenarios). We tried to work around this by catching one particular exception and calling PlatformRemoveAll() to try and delete the shared prefs so we could create a new set, however this logic was flawed since the error occurs when getting an instance of the encrypted shared preferences, which the PlatformRemoveAll attempts to do itself (so it would fail to get the thing to remove the thing). This changes up the logic a bit and directly clears the shared preference that the encrypted one is stored in, without first trying to get an instance of the corrupt shared prefs. It then also tries to directly create a new instance afterwards, and return that, in an attempt to make this failsafe / reset operation transparent to the original call to get or set a secure storage key/value. * Reuse Alias property that already exists
Configuration menu - View commit details
-
Copy full SHA for c6600c6 - Browse repository at this point
Copy the full SHA c6600c6View commit details
Commits on Aug 31, 2024
-
894511 : Shell Tab is still visible after set Tab.IsVisible to false (#…
…24161) * 894511 : Shell Tab is still visible after set Tab.IsVisible to false * Commit for test cases changes * 894511 : Review changes * Commit for testcase changes * Commit for proper flyout width * Review changes * Image added * 894511 : Commit for windows * 894511 : Fix for iOS included * Fix: 894511 : Review changes * Fix:894511 : Images Added
Configuration menu - View commit details
-
Copy full SHA for 1dfe609 - Browse repository at this point
Copy the full SHA 1dfe609View commit details
Commits on Sep 2, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 974a495 - Browse repository at this point
Copy the full SHA 974a495View commit details
Commits on Sep 3, 2024
-
Configuration menu - View commit details
-
Copy full SHA for e44d88c - Browse repository at this point
Copy the full SHA e44d88cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 60b9a69 - Browse repository at this point
Copy the full SHA 60b9a69View commit details -
Always return Granted for Read-Write Storage permissions on Android (#…
…23909) * Always return Granted for Read-Write Storage * Add test * Apply suggestions from code review * Update test * Make test specific to Android
Configuration menu - View commit details
-
Copy full SHA for 31ed71f - Browse repository at this point
Copy the full SHA 31ed71fView commit details -
Merge branch 'main' into merge_main_net0
# Conflicts: # src/Essentials/src/PublicAPI/net-android/PublicAPI.Unshipped.txt
Configuration menu - View commit details
-
Copy full SHA for 1274621 - Browse repository at this point
Copy the full SHA 1274621View commit details -
Configuration menu - View commit details
-
Copy full SHA for ab5c3d5 - Browse repository at this point
Copy the full SHA ab5c3d5View commit details