-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BarBackground with Brush in TabbedPage on theme change #24425
base: main
Are you sure you want to change the base?
Conversation
Hey there @kubaflo! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
8c7043a
to
e384e21
Compare
5cc3837
to
5271e66
Compare
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
does this fixes #24428 too ? |
Hi, |
/rebase |
bffddbe
to
12be290
Compare
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test is failing on iOS. Could you update the snapshot?
VisualTestUtils.VisualTestFailedException :
Snapshot different than baseline: GradientInTabBarShouldChange.png (size differs - baseline is 1124x2326 pixels, actual is 1124x2286 pixels)
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
Issues Fixed
Fixes #24356
Screen.Recording.2024-08-25.at.16.48.33.mov