Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BarBackground with Brush in TabbedPage on theme change #24425

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

kubaflo
Copy link
Contributor

@kubaflo kubaflo commented Aug 25, 2024

Issues Fixed

Fixes #24356

Screen.Recording.2024-08-25.at.16.48.33.mov

@kubaflo kubaflo requested a review from a team as a code owner August 25, 2024 14:58
@kubaflo kubaflo requested review from Eilon and rmarinho August 25, 2024 14:58
@dotnet-policy-service dotnet-policy-service bot added the community ✨ Community Contribution label Aug 25, 2024
Copy link
Contributor

Hey there @kubaflo! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@kubaflo kubaflo force-pushed the fix-24356 branch 2 times, most recently from 8c7043a to e384e21 Compare August 25, 2024 16:12
@kubaflo kubaflo changed the title Update a tabbar with gradient on app theme change BarBackground with Brush in TabbedPage on theme change Aug 25, 2024
@kubaflo kubaflo force-pushed the fix-24356 branch 2 times, most recently from 5cc3837 to 5271e66 Compare August 25, 2024 23:17
@rmarinho
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@rmarinho
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@StephaneDelcroix
Copy link
Contributor

does this fixes #24428 too ?

@kubaflo
Copy link
Contributor Author

kubaflo commented Sep 4, 2024

does this fixes #24428 too ?

No, #24429 fixes 24428

@AlleSchonWeg
Copy link

Hi,
i'm waiting for this fix. Is there a problem with this PR?
Thank you

@jsuarezruiz
Copy link
Contributor

/rebase

@jsuarezruiz
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test is failing on iOS. Could you update the snapshot?

VisualTestUtils.VisualTestFailedException :
Snapshot different than baseline: GradientInTabBarShouldChange.png (size differs - baseline is 1124x2326 pixels, actual is 1124x2286 pixels)

@jsuarezruiz
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-controls-tabbedpage TabbedPage community ✨ Community Contribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AppThemeBinding BarBackground with Brush in NavigationPage and TabbedPage not working
6 participants