Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove building the runtime for ESP32 #2057

Closed
wants to merge 1 commit into from
Closed

Remove building the runtime for ESP32 #2057

wants to merge 1 commit into from

Conversation

pgrawehr
Copy link
Contributor

@pgrawehr pgrawehr commented Mar 19, 2023 •
edited by ghost
Loading

Re-enables the Arduino build, but disables building for the ESP32. Not really needed
for the tests and keeps failing.

Microsoft Reviewers: Open in CodeFlow

@pgrawehr
Remove building the runtime for ESP32
e43d762 
Often runs out of memory in the pipeline. Should rather
be done on the ExtendedConfigurableFirmata repo instead.
krwq
krwq approved these changes Mar 19, 2023
View reviewed changes
Copy link
Member

@krwq krwq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming CI is green

@krwq
Copy link
Member

krwq commented Mar 19, 2023

Flaky test:

    System.Device.Gpio.Tests.LibGpiodDriverTests.FastInterruptHandling [FAIL]
      Expected at least 99, got only 98
      Expected: True
      Actual:   False
      Stack Trace:
        /_/src/System.Device.Gpio.Tests/GpioControllerTestBase.cs(577,0): at System.Device.Gpio.Tests.GpioControllerTestBase.FastInterruptHandling()

@Ellerbach Ellerbach added the * NO MERGE * The PR is not ready for merge yet (see discussion for detailed reasons) label Jul 20, 2023
@pgrawehr
Copy link
Contributor Author

Superseeded by #2240

@pgrawehr pgrawehr closed this Jan 11, 2024
@pgrawehr pgrawehr removed the * NO MERGE * The PR is not ready for merge yet (see discussion for detailed reasons) label Jan 11, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Feb 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@krwq krwq krwq approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pgrawehr @krwq @Ellerbach