#5737 Expose Current ConventionSet #5741
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @rjperes, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution! TTYL, DNFBOT; |
|
Weird... The only change was the addition of a property... if the tests are failing, then they are already failing in the source branch, from which I forked! |
|
@rjperes - Tests are failing because the property which is added needs to be virtual. |
|
@rjperes Thanks for your contribution. Unfortunately it goes against the design we are pursuing. Please see #5737 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple change, just expose the private ConventionSet so that we can add to the current conventions.
Please see #5737 and https://weblogs.asp.net/ricardoperes/implementing-missing-features-in-entity-framework-core-part-4-conventions for a description of the problem.