Set <LangVersion> to preview #35121
Merged
Set <LangVersion> to preview #35121
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #35100
In #35100, a C# language change caused a break in an EF scenario; if we want to detect this kind of thing early, we need to set our project's
<LangVersion>to preview. This is similar to how we update our .NET SDK to use preview bits - basically just making sure we work with the latest state of everything.This does have some potentially negative consequences: we may (inadvertently) introduce C# preview features into the codebase, which may later be reverted or changed.
I'll bring this to design to see what we think.