Further improve model building performance #11526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndriySvyryd
force-pushed
the
Issue9347
branch
2 times, most recently
from
5db649a to
d00ba59
Compare
smitpatel
reviewed
Apr 4, 2018
| @@ -183,27 +177,25 @@ public virtual bool Apply(InternalEntityTypeBuilder entityTypeBuilder, EntityTyp | |||
| public virtual bool Apply(InternalEntityTypeBuilder entityTypeBuilder, string ignoredMemberName) | |||
| { | |||
| var navigationPropertyInfo = | |||
| entityTypeBuilder.Metadata.ClrType.GetRuntimeProperties().FirstOrDefault(p => p.Name == ignoredMemberName); | |||
| entityTypeBuilder.Metadata.GetRuntimeProperties()?.Find(ignoredMemberName); | |||
| if (navigationPropertyInfo == null) | |||
| { | |||
| return true; | |||
| } | |||
|
|
|||
| var targetClrType = FindCandidateNavigationPropertyType(navigationPropertyInfo); | |||
There was a problem hiding this comment.
Could DRY this with if condition in a private function
smitpatel
reviewed
Apr 4, 2018
| if (clrProperties.Count > 0) | ||
| foreach (var clrProperty in clrProperties) | ||
| { | ||
| var actualProperty = entityType.GetRuntimeProperties().Find(clrProperty); |
There was a problem hiding this comment.
Do we need Find here since it was First earlier? Direct key access?
Memoize DisplayName() for Type Call Attribute.IsDefined before GetCustomAttributes() Use in parameters for TypeMappingInfo and RelationalTypeMappingInfo Implement IEquatable<T> on TypeMappingInfo and RelationalTypeMappingInfo Fixes #9347
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cache property and field infos
Memoize DisplayName() for Type
Call Attribute.IsDefined before GetCustomAttributes()
Use in parameters for TypeMappingInfo and RelationalTypeMappingInfo
Implement IEquatable on TypeMappingInfo and RelationalTypeMappingInfo
Fixes #9347