Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Temporarily exclude flaky tests #7615

Merged
merged 1 commit into from
Nov 6, 2024
Merged

Temporarily exclude flaky tests #7615

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Tests/CollectionRuleActions.UnitTests/CollectDumpActionTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ public CollectDumpActionTests(ITestOutputHelper outputHelper)
_endpointUtilities = new(_outputHelper);
}

[Theory]
[Theory(Skip = "Flaky")]
[MemberData(nameof(ActionTestsHelper.GetTfmsAndDumpTypes), MemberType = typeof(ActionTestsHelper))]
public Task CollectDumpAction_Success(TargetFrameworkMoniker tfm, DumpType dumpType)
{
Expand Down
2 changes: 1 addition & 1 deletion src/Tests/Microsoft.Diagnostics.Monitoring.Tool.FunctionalTests/CollectionRuleTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ await ScenarioRunner.SingleTarget(
/// Validates that a non-startup rule will complete when it has an action limit specified
/// without a sliding window duration.
/// </summary>
[Theory]
[Theory(Skip = "Flaky")]
[InlineData(DiagnosticPortConnectionMode.Listen)]
public async Task CollectionRule_ActionLimitTest(DiagnosticPortConnectionMode mode)
{
Expand Down
4 changes: 2 additions & 2 deletions src/Tests/Microsoft.Diagnostics.Monitoring.Tool.FunctionalTests/ExceptionsTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -348,7 +348,7 @@ await ScenarioRunner.SingleTarget(
});
}

[Theory]
[Theory(Skip = "Flaky")]
[MemberData(nameof(ProfilerHelper.GetArchitecture), MemberType = typeof(ProfilerHelper))]
public async Task Exceptions_FilterIncludeBasic(Architecture targetArchitecture)
{
Expand Down Expand Up @@ -387,7 +387,7 @@ await ScenarioRunner.SingleTarget(
});
}

[Theory]
[Theory(Skip = "Flaky")]
[MemberData(nameof(ProfilerHelper.GetArchitecture), MemberType = typeof(ProfilerHelper))]
public async Task Exceptions_FilterIncludeMultiple(Architecture targetArchitecture)
{
Expand Down