-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Parameter Capturing] Make probe management APIs asynchronous #5125
Merged
schmittjoseph
merged 22 commits into
dotnet:feature/parameter-capturing
from
schmittjoseph:probe-async-callbacks
Aug 18, 2023
Merged
[Parameter Capturing] Make probe management APIs asynchronous #5125
schmittjoseph
merged 22 commits into
dotnet:feature/parameter-capturing
from
schmittjoseph:probe-async-callbacks
Aug 18, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
needs-review
label
Aug 10, 2023
schmittjoseph
changed the title
[do not review] [Parameter Capturing] Make probe management APIs asynchronous
[Parameter Capturing] Make probe management APIs asynchronous
Aug 10, 2023
schmittjoseph
commented
Aug 10, 2023
src/Profilers/MutatingMonitorProfiler/ProbeInstrumentation/ProbeInstrumentation.cpp
Show resolved
Hide resolved
schmittjoseph
commented
Aug 10, 2023
...rosoft.Diagnostics.Monitoring.HostingStartup/ParameterCapturing/ParameterCapturingService.cs
Show resolved
Hide resolved
schmittjoseph
commented
Aug 11, 2023
...nostics.Monitoring.HostingStartup/ParameterCapturing/FunctionProbes/FunctionProbesManager.cs
Outdated
Show resolved
Hide resolved
wiktork
reviewed
Aug 16, 2023
...nostics.Monitoring.HostingStartup/ParameterCapturing/FunctionProbes/FunctionProbesManager.cs
Outdated
Show resolved
Hide resolved
ghost
removed
the
needs-review
label
Aug 16, 2023
wiktork
reviewed
Aug 16, 2023
...nostics.Monitoring.HostingStartup/ParameterCapturing/FunctionProbes/FunctionProbesManager.cs
Show resolved
Hide resolved
schmittjoseph
commented
Aug 16, 2023
src/Profilers/MutatingMonitorProfiler/ProbeInstrumentation/ProbeInstrumentation.h
Outdated
Show resolved
Hide resolved
…beInstrumentation.h
ghost
added
the
needs-review
label
Aug 16, 2023
wiktork
reviewed
Aug 16, 2023
...gnostics.Monitoring.HostingStartup/ParameterCapturing/Pipeline/ParameterCapturingPipeline.cs
Outdated
Show resolved
Hide resolved
schmittjoseph
commented
Aug 16, 2023
...nostics.Monitoring.HostingStartup/ParameterCapturing/FunctionProbes/FunctionProbesManager.cs
Show resolved
Hide resolved
wiktork
reviewed
Aug 16, 2023
src/Profilers/MutatingMonitorProfiler/ProbeInstrumentation/ProbeInstrumentation.cpp
Outdated
Show resolved
Hide resolved
ghost
added
the
needs-review
label
Aug 16, 2023
wiktork
reviewed
Aug 16, 2023
...nostics.Monitoring.HostingStartup/ParameterCapturing/FunctionProbes/FunctionProbesManager.cs
Show resolved
Hide resolved
…nto probe-async-callbacks
ghost
added
the
needs-review
label
Aug 16, 2023
wiktork
reviewed
Aug 16, 2023
...nostics.Monitoring.HostingStartup/ParameterCapturing/FunctionProbes/FunctionProbesManager.cs
Outdated
Show resolved
Hide resolved
ghost
removed
the
needs-review
label
Aug 17, 2023
wiktork
previously approved these changes
Aug 17, 2023
jander-msft
reviewed
Aug 17, 2023
...nostics.Monitoring.HostingStartup/ParameterCapturing/FunctionProbes/FunctionProbesManager.cs
Show resolved
Hide resolved
ghost
removed
the
needs-review
label
Aug 17, 2023
jander-msft
reviewed
Aug 17, 2023
...nostics.Monitoring.HostingStartup/ParameterCapturing/FunctionProbes/FunctionProbesManager.cs
Show resolved
Hide resolved
jander-msft
reviewed
Aug 17, 2023
...gnostics.Monitoring.HostingStartup/ParameterCapturing/Pipeline/ParameterCapturingPipeline.cs
Show resolved
Hide resolved
jander-msft
reviewed
Aug 17, 2023
src/Profilers/MutatingMonitorProfiler/ProbeInstrumentation/ProbeInstrumentation.cpp
Show resolved
Hide resolved
jander-msft
reviewed
Aug 17, 2023
...rosoft.Diagnostics.Monitoring.HostingStartup/ParameterCapturing/ParameterCapturingService.cs
Show resolved
Hide resolved
ghost
added
the
needs-review
label
Aug 17, 2023
jander-msft
approved these changes
Aug 17, 2023
ghost
removed
the
needs-review
label
Aug 17, 2023
schmittjoseph
merged commit Aug 18, 2023
88de6a3
into
dotnet:feature/parameter-capturing
26 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR converts the probe management APIs to be asynchronous. The prior behavior was to submit requests to our profiler without any feedback on if the requests succeeded or failed. Now the results of requests are reported back to our managed code so we can act on it accordingly.
High-level changes:
ParameterCapturingService
.ProbeInstrumentation::InitBackgroundService
for an explanation of why this is necessary).FunctionProbesManager
now maintains an internal state to properly handle callbacks and transition its new task completion sources as necessary.Out of scope of this PR:
Release Notes Entry