Represent TimeSpan as formatted string in OpenAPI #5124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
src/Tools/dotnet-monitor/Swagger/SwaggerGenOptionsExtensions.cs
Outdated
Show resolved
Hide resolved
schmittjoseph
approved these changes
Aug 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
These changes make sure that
TimeSpanis represented as a formatted string in the OpenAPI; this better describes the expected output (see collection rule details example: https://github.com/dotnet/dotnet-monitor/blob/main/documentation/api/collectionrules-get.md#sample-response) as well as leads to better code generation for generating HTTP clients so that the built-inTimeSpanis used rather than generating a new type.Release Notes Entry