Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Change generated HTML encoding to UTF-8N (without BOM) #10069

Merged
merged 2 commits into from
Oct 19, 2024

Conversation

filzrev
Copy link
Contributor

@filzrev filzrev commented Jul 6, 2024

This PR intended to fix #9545.

Currently docfx generates UTF-8 encoded HTML files with BOM.
This PR change output file encoding to UTF-8N (without BOM)

This change introduce BREAKING CHANGES for some users who depends on BOM.
But it' required for consistency. (Because docfx template files are already using UTF-8N).

@yufeih yufeih added the breaking-change Makes the pull request appear in "Breaking Changes" section of the next release note label Oct 19, 2024
@yufeih yufeih merged commit 6b52636 into dotnet:main Oct 19, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change Makes the pull request appear in "Breaking Changes" section of the next release note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Change output html file encoding to UTF-8 (No BOM)
2 participants