-
Notifications
You must be signed in to change notification settings - Fork 469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Npgsql EF Core integration to latest versions #6721
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we also remove the following as part of this change:
Lines 9 to 10 in 95eec9c
<!-- We need to ingest the stable version of EF npgsql in order for us to produce stable bits. --> | |
<SuppressFinalPackageVersion>true</SuppressFinalPackageVersion> |
Also update Npgsql DependencyInjection and OpenTelemetry to latest version, since these are referenced by the EF package.
Good call. Removed. |
/backport to release/9.0 |
Started backporting to release/9.0: https://github.com/dotnet/aspire/actions/runs/11903378396 |
@eerhardt backporting to release/9.0 failed, the patch most likely resulted in conflicts: $ git am --3way --empty=keep --ignore-whitespace --keep-non-patch changes.patch
Applying: Update Npgsql EF Core integration to latest versions
Applying: Remove SuppressFinalPackageVersion so it ships stable
Using index info to reconstruct a base tree...
M Directory.Packages.props
Falling back to patching base and 3-way merge...
Auto-merging Directory.Packages.props
CONFLICT (content): Merge conflict in Directory.Packages.props
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0002 Remove SuppressFinalPackageVersion so it ships stable
Error: The process '/usr/bin/git' failed with exit code 128 Please backport manually! |
@eerhardt an error occurred while backporting to release/9.0, please check the run log for details! Error: git am failed, most likely due to a merge conflict. |
This will allow us to ship
Aspire.Npgsql.EntityFrameworkCore.PostgreSQL
as stable9.0.0
. This should be backported to release/9.0.Microsoft Reviewers: Open in CodeFlow