Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding OpaqueCOM structs #2234

Open
wants to merge 9 commits into
base: develop/3.0
Choose a base branch
from

Conversation

curin
Copy link
Contributor

@curin curin commented Jun 26, 2024

Summary of the PR

This PR will include the following:

-Opaque COM struct mod

  • Modifies COM interface structs to act as ComPtrs behind the scenes

mostly identical to 2.X
@curin curin changed the base branch from main to develop/3.0 June 26, 2024 04:31
@curin curin changed the title Adding ComPtr Adding OpaqueCOM structs Jun 26, 2024
This reverts commit ceb6d3b.
Also added updated bindings for d3dCommon
-Added paratheses around dereference statements
- Rename Interface BaseTypes to match new COM names
- Handle when there already exists a type with the new COM name
- Add new Ref2D constructor for usage with OpaqueComTypes
@curin curin marked this pull request as ready for review July 2, 2024 00:59
@curin curin requested a review from a team as a code owner July 2, 2024 00:59
- MergeCompilationUnits moved to private for now
- Included a dxcore_interface changes to show one of the new opaque classes being used as an input into a function
- Added IUnknown as it is a requirement for all COM objects
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

1 participant