[2.X] Add a helper for custom IO in Assimp #2199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is ready for review. |
alexrp
reviewed
May 29, 2024
Beyley
requested changes
Jun 11, 2024
Comment on lines
175
to
178
| if (GCHandle.FromIntPtr((nint) file->UserData).Target is not Stream s) | ||
| { | ||
| throw new InvalidOperationException("Invalid UserData for File."); | ||
| } |
There was a problem hiding this comment.
This function can probably be wrapped into a Stream s = GetStreamFromUserData(file->UserData);, which would de-duplicate a lot of code here
Beyley
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the PR
Adds a CustomFileIO class which allows a Stream factory to be used in the context of a FileIO implementation in Assimp.
Related issues, Discord discussions, or proposals
https://discord.com/channels/521092042781229087/607634593201520651/1245146529468121138
Further Comments