Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version5 auditmode #2016

Merged
merged 1 commit into from
Jun 11, 2024
Merged

Version5 auditmode #2016

merged 1 commit into from
Jun 11, 2024

Conversation

SeppPenner
Copy link
Collaborator

Fixes #1943 as requested in #1943 (comment).

@chkr1011 I still have an issue I don't understand:

MQTTnet.Benchmarks throws:

CS8892
Die Methode "TestingPlatformEntryPoint.Main(string[])" wird nicht als Einstiegspunkt verwendet,
weil ein synchroner Einstiegspunkt "Program.Main(string[])" gefunden wurde.
MQTTnet.Benchmarks (net8.0)	D:\Source\MQTTnet.Benchmarks\obj\Debug\net8.0\TestPlatformEntryPoint.cs
Die Methode "TestingPlatformEntryPoint.Main(string[])" wird nicht als Einstiegspunkt verwendet,
weil ein synchroner Einstiegspunkt "Program.Main(string[])" gefunden wurde.

Do you have an idea here?

Let me know if I need to change something here.

@SeppPenner SeppPenner changed the base branch from master to version5 June 4, 2024 15:15
@chkr1011
Copy link
Collaborator

chkr1011 commented Jun 8, 2024

I also got this error while working on the version5 branch and it seems to me that Benchmark.NET generates its own main method since a certain version but we still have our own so that we can pick the right benchmark etc. We may need to check the best practices of Benchmark.NET and see how we should structure the benchmarks. We may also remove the benchmarks from the project completely because they are not used very often and can be created on demand without being part of the repository.

In my opinion we can disable warning as error for the benchmarks so go ahead.

@chkr1011 chkr1011 merged commit 08f0d03 into version5 Jun 11, 2024
4 of 5 checks passed
@chkr1011 chkr1011 deleted the version5-auditmode branch June 11, 2024 16:03
chkr1011 added a commit that referenced this pull request Aug 24, 2024
* Remove WebSocket4Net extension library

* Remove UWP support

* Drop support for all old frameworks

* Update CI

* Update CI

* Update CI

* Update CI

* Remove obsolete code

* Set default protocol version to 5.0.0

* Remove obsolete tests

* Remove old dependencies

* Reset release notes

* Move server to dedicated project

* Fix unit tests

* Update and cleanup nuget packages

* Fix unit tests
Refactor code

* No longer throw exception when receiving non success CONNACK

* Enable nuget signing

* Enable nuget signing

* Enable nuget signing

* Enable nuget signing

* Enable nuget signing

* Enable nuget signing

* Enable nuget signing

* Enable nuget signing

* Enable code signing

* Enable code signing

* Enable code signing

* Fix client endpoint handling

* Improve CI

* Fix CI

* Fix CI

* Fix CI

* Fix CI

* Import changes from version 4

* Cleanup target frameworks and remove obsolete code

* Drop support for dotnet7.0

* Remove managed client

* Version5 auditmode (#2016)

Added NuGet audit mode and some other settings to get informed about security issues.

* Address warnings from analyzers

* Support for ReadOnlySequence as payload (#2046)

* use ReadOnlySequence as payload

* fix build

* fix build

* skip sign in forks

* remove unnecessary owner

* tests and extensions

* remove test

* simplify WritePacketBuffer, remove unused helper

* Adjust namespaces

* Fix build errors

* Import latest fixes from main branch

* Adjust namespaces

---------

Co-authored-by: SeppPenner <[email protected]>
Co-authored-by: Martin Regen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Security alerts on MQTTnet.AspNetCore
2 participants